libsForQt5.messagelib: add patch for compatibility with cmake 3.24#186967
Merged
vcunat merged 2 commits intoNixOS:masterfrom Aug 18, 2022
Merged
libsForQt5.messagelib: add patch for compatibility with cmake 3.24#186967vcunat merged 2 commits intoNixOS:masterfrom
vcunat merged 2 commits intoNixOS:masterfrom
Conversation
Member
Author
|
What a bad timing, right after the nodejs bump, now building qtwebengine in nixpkgs-review. |
vcunat
approved these changes
Aug 16, 2022
Member
vcunat
left a comment
There was a problem hiding this comment.
libsForQt5.mailcommon builds for me.
Member
Author
|
Result of 28 packages marked as broken and skipped:
12 packages built:
|
Member
|
That broken list seems rather suspicious to me. EDIT details: some of the first ones aren't marked as broken for me (x86_64-linux) and build locally (and built in the last Hydra eval). I haven't looked at the whole list. |
Member
Author
Most of them should be correct, the first four evaluate correctly manually, maybe nixpkgs-review got it wrong. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description of changes
Things done
sandbox = trueset innix.conf? (See Nix manual)nix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage./result/bin/)nixos/doc/manual/md-to-db.shto update generated release notes