Skip to content

libsForQt5.messagelib: add patch for compatibility with cmake 3.24#186967

Merged
vcunat merged 2 commits intoNixOS:masterfrom
NickCao:messagelib
Aug 18, 2022
Merged

libsForQt5.messagelib: add patch for compatibility with cmake 3.24#186967
vcunat merged 2 commits intoNixOS:masterfrom
NickCao:messagelib

Conversation

@NickCao
Copy link
Member

@NickCao NickCao commented Aug 16, 2022

Description of changes
Things done
  • Built on platform(s)
    • x86_64-linux
    • aarch64-linux
    • x86_64-darwin
    • aarch64-darwin
  • For non-Linux: Is sandbox = true set in nix.conf? (See Nix manual)
  • Tested, as applicable:
  • Tested compilation of all packages that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage
  • Tested basic functionality of all binary files (usually in ./result/bin/)
  • 22.11 Release Notes (or backporting 22.05 Release notes)
    • (Package updates) Added a release notes entry if the change is major or breaking
    • (Module updates) Added a release notes entry if the change is significant
    • (Module addition) Added a release notes entry if adding a new NixOS module
    • (Release notes changes) Ran nixos/doc/manual/md-to-db.sh to update generated release notes
  • Fits CONTRIBUTING.md.

@NickCao NickCao requested a review from ttuegel as a code owner August 16, 2022 14:00
@github-actions github-actions bot added the 6.topic: qt/kde Object-oriented framework for GUI creation label Aug 16, 2022
@ofborg ofborg bot added the 8.has: clean-up This PR removes packages or removes other cruft label Aug 16, 2022
@ofborg ofborg bot requested a review from nyanloutre August 16, 2022 14:09
@ofborg ofborg bot added 10.rebuild-darwin: 0 This PR does not cause any packages to rebuild on Darwin. 10.rebuild-linux: 11-100 This PR causes between 11 and 100 packages to rebuild on Linux. labels Aug 16, 2022
@NickCao
Copy link
Member Author

NickCao commented Aug 16, 2022

What a bad timing, right after the nodejs bump, now building qtwebengine in nixpkgs-review.

Copy link
Member

@vcunat vcunat left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

libsForQt5.mailcommon builds for me.

@NickCao
Copy link
Member Author

NickCao commented Aug 16, 2022

Result of nixpkgs-review pr 186967 run on x86_64-linux 1

28 packages marked as broken and skipped:
  • akregator
  • kaddressbook
  • kmail
  • kontact
  • libsForQt512.akonadi-import-wizard
  • libsForQt512.akonadiconsole
  • libsForQt512.akregator
  • libsForQt512.kaddressbook
  • libsForQt512.kalarm
  • libsForQt512.kdepim-addons
  • libsForQt512.kmail
  • libsForQt512.kontact
  • libsForQt512.mailcommon
  • libsForQt512.mbox-importer
  • libsForQt512.messagelib
  • libsForQt512.pim-data-exporter
  • libsForQt514.akonadi-import-wizard
  • libsForQt514.akonadiconsole
  • libsForQt514.akregator
  • libsForQt514.kaddressbook
  • libsForQt514.kalarm
  • libsForQt514.kdepim-addons
  • libsForQt514.kmail
  • libsForQt514.kontact
  • libsForQt514.mailcommon
  • libsForQt514.mbox-importer
  • libsForQt514.messagelib
  • libsForQt514.pim-data-exporter
12 packages built:
  • libsForQt5.akonadi-import-wizard
  • libsForQt5.akonadiconsole
  • libsForQt5.akregator
  • libsForQt5.kaddressbook
  • libsForQt5.kalarm
  • libsForQt5.kdepim-addons
  • libsForQt5.kmail
  • libsForQt5.kontact
  • libsForQt5.mailcommon
  • libsForQt5.mbox-importer
  • libsForQt5.messagelib
  • libsForQt5.pim-data-exporter

@bobby285271 bobby285271 added the 12.approvals: 1 This PR was reviewed and approved by one person. label Aug 16, 2022
@vcunat
Copy link
Member

vcunat commented Aug 16, 2022

That broken list seems rather suspicious to me.

EDIT details: some of the first ones aren't marked as broken for me (x86_64-linux) and build locally (and built in the last Hydra eval). I haven't looked at the whole list.

@NickCao
Copy link
Member Author

NickCao commented Aug 16, 2022

minQtVersion = "5.15";
broken = lib.versionOlder libsForQt5.qtbase.version minQtVersion;

Most of them should be correct, the first four evaluate correctly manually, maybe nixpkgs-review got it wrong.

@vcunat vcunat merged commit 3b765cc into NixOS:master Aug 18, 2022
@NickCao NickCao deleted the messagelib branch August 18, 2022 07:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

6.topic: qt/kde Object-oriented framework for GUI creation 8.has: clean-up This PR removes packages or removes other cruft 10.rebuild-darwin: 0 This PR does not cause any packages to rebuild on Darwin. 10.rebuild-linux: 11-100 This PR causes between 11 and 100 packages to rebuild on Linux. 12.approvals: 1 This PR was reviewed and approved by one person.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants