Conversation
amaxine
approved these changes
Aug 14, 2022
Contributor
amaxine
left a comment
There was a problem hiding this comment.
No relevant changes afaict https://gitlab.gnome.org/GNOME/gjs/-/compare/1.72.1...1.72.2
Contributor
|
@ofborg build gjs.tests I cannot reproduce failure locally 🤔 |
Member
|
The failure is likely #171069 (comment). |
Contributor
|
Backport failed for Please cherry-pick the changes locally. git fetch origin staging-22.05
git worktree add -d .worktree/backport-186522-to-staging-22.05 origin/staging-22.05
cd .worktree/backport-186522-to-staging-22.05
git checkout -b backport-186522-to-staging-22.05
ancref=$(git merge-base 69f3e761d69f25d097f24e4a573a0b8aaf85c58c a1987d189bf91d1b192e76b9c7465adc1d484475)
git cherry-pick -x $ancref..a1987d189bf91d1b192e76b9c7465adc1d484475 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Automatic update generated by nixpkgs-update tools. This update was made based on information from passthru.updateScript.
meta.description for gjs is: "JavaScript bindings for GNOME"
meta.homepage for gjs is: "https://gitlab.gnome.org/GNOME/gjs/blob/master/doc/Home.md"
meta.changelog for gjs is: ""
Updates performed
To inspect upstream changes
Impact
Checks done (click to expand)
Rebuild report (if merged into master) (click to expand)
Instructions to test this update (click to expand)
Either download from Cachix:
(The Cachix cache is only trusted for this store-path realization.)
For the Cachix download to work, your user must be in the
trusted-userslist or you can usesudosince root is effectively trusted.Or, build yourself:
After you've downloaded or built it, look at the files and if there are any, run the binaries:
Pre-merge build results
NixPkgs review skipped
Maintainer pings
cc @bobby285271 @hedning @jtojnar @dasj19 @maxeaubrey for testing.