Skip to content

haskellPackages: unbreak nvim-hs-contrib#186458

Merged
cdepillabout merged 1 commit intoNixOS:haskell-updatesfrom
phijor:haskellPackages/nvim-hs-contrib-v2.0.0.1
Aug 13, 2022
Merged

haskellPackages: unbreak nvim-hs-contrib#186458
cdepillabout merged 1 commit intoNixOS:haskell-updatesfrom
phijor:haskellPackages/nvim-hs-contrib-v2.0.0.1

Conversation

@phijor
Copy link
Contributor

@phijor phijor commented Aug 13, 2022

Description of changes

Version 2.0.0.1 of nvim-hs-contrib was released on Hackage, which fixes compilation with GHC 9.

Things done
  • Built on platform(s)
    • x86_64-linux
    • aarch64-linux
    • x86_64-darwin
    • aarch64-darwin
  • For non-Linux: Is sandbox = true set in nix.conf? (See Nix manual)
  • Tested, as applicable:
  • Tested compilation of all packages that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage
  • Tested basic functionality of all binary files (usually in ./result/bin/)
  • 22.11 Release Notes (or backporting 22.05 Release notes)
    • (Package updates) Added a release notes entry if the change is major or breaking
    • (Module updates) Added a release notes entry if the change is significant
    • (Module addition) Added a release notes entry if adding a new NixOS module
    • (Release notes changes) Ran nixos/doc/manual/md-to-db.sh to update generated release notes
  • Fits CONTRIBUTING.md.

Version 2.0.0.1 of nvim-hs-contrib was released on Hackage, which fixes
compilation with GHC 9.
@github-actions github-actions bot added the 6.topic: haskell General-purpose, statically typed, purely functional programming language label Aug 13, 2022
@ofborg ofborg bot added 8.has: package (new) This PR adds a new package 10.rebuild-darwin: 1-10 This PR causes between 1 and 10 packages to rebuild on Darwin. 10.rebuild-darwin: 1 This PR causes 1 package to rebuild on Darwin. 10.rebuild-linux: 1-10 This PR causes between 1 and 10 packages to rebuild on Linux. 10.rebuild-linux: 1 This PR causes 1 package to rebuild on Linux. labels Aug 13, 2022
@cdepillabout
Copy link
Member

@ofborg build haskellPackages.nvim-hs-contrib

@cdepillabout
Copy link
Member

Looks good, thanks!

One tip: if you name the PR title and(?) commit message to start with the full package name, ofborg will automatically try to compile it. In this case the commit message and PR title should be something like haskellPackages.nvim-hs-contrib: unbreak

@cdepillabout cdepillabout merged commit 7528dfe into NixOS:haskell-updates Aug 13, 2022
@phijor
Copy link
Contributor Author

phijor commented Aug 13, 2022

One tip: if you name the PR title and(?) commit message to start with the full package name, ofborg will automatically try to compile it. In this case the commit message and PR title should be something like haskellPackages.nvim-hs-contrib: unbreak

Ohhh great, thanks a lot for the tip. I will try that next time :)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

6.topic: haskell General-purpose, statically typed, purely functional programming language 8.has: package (new) This PR adds a new package 10.rebuild-darwin: 1-10 This PR causes between 1 and 10 packages to rebuild on Darwin. 10.rebuild-darwin: 1 This PR causes 1 package to rebuild on Darwin. 10.rebuild-linux: 1-10 This PR causes between 1 and 10 packages to rebuild on Linux. 10.rebuild-linux: 1 This PR causes 1 package to rebuild on Linux.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants