Skip to content

python3.pkgs.tensorflow: 2.9.1 -> 2.10.0-rc0 (fix build)#185837

Merged
Mic92 merged 1 commit intoNixOS:masterfrom
Mic92:tensorflow
Aug 10, 2022
Merged

python3.pkgs.tensorflow: 2.9.1 -> 2.10.0-rc0 (fix build)#185837
Mic92 merged 1 commit intoNixOS:masterfrom
Mic92:tensorflow

Conversation

@Mic92
Copy link
Member

@Mic92 Mic92 commented Aug 9, 2022 •
edited
Loading

Description of changes

#182917 broke the tensorflow build

Things done
  • Built on platform(s)
    • x86_64-linux
    • aarch64-linux
    • x86_64-darwin
    • aarch64-darwin
  • For non-Linux: Is sandbox = true set in nix.conf? (See Nix manual)
  • Tested, as applicable:
  • Tested compilation of all packages that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage
  • Tested basic functionality of all binary files (usually in ./result/bin/)
  • 22.11 Release Notes (or backporting 22.05 Release notes)
    • (Package updates) Added a release notes entry if the change is major or breaking
    • (Module updates) Added a release notes entry if the change is significant
    • (Module addition) Added a release notes entry if adding a new NixOS module
    • (Release notes changes) Ran nixos/doc/manual/md-to-db.sh to update generated release notes
  • Fits CONTRIBUTING.md.

@Mic92 Mic92 requested review from FRidh and jonringer as code owners August 9, 2022 20:50
@github-actions github-actions bot added the 6.topic: python Python is a high-level, general-purpose programming language. label Aug 9, 2022
Mic92
Mic92 commented Aug 9, 2022
View reviewed changes
pkgs/development/python-modules/tensorflow/default.nix Outdated
Copy link
Member Author

@Mic92 Mic92 Aug 9, 2022

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Still need to fix the other checksums.

@ofborg ofborg bot requested a review from abbradar August 9, 2022 20:59
@ofborg ofborg bot added 10.rebuild-darwin: 11-100 This PR causes between 11 and 100 packages to rebuild on Darwin. 10.rebuild-linux: 11-100 This PR causes between 11 and 100 packages to rebuild on Linux. labels Aug 9, 2022
@Mic92
Copy link
Member Author

Mic92 commented Aug 9, 2022

@ofborg build python3.pkgs.tensorflow

@Mic92
Copy link
Member Author

Mic92 commented Aug 9, 2022

@ofborg build python3.pkgs.tensorflow

@Mic92 Mic92 force-pushed the tensorflow branch 2 times, most recently from 43c67ab to de7ff3c Compare August 9, 2022 21:19
@Mic92
Copy link
Member Author

Mic92 commented Aug 9, 2022

@ofborg build python3.pkgs.tensorflow

@Mic92
Copy link
Member Author

Mic92 commented Aug 10, 2022

I cannot fix the darwin package: cc @veprbl
I would merge it anyway since also the linux package is broken atm.

@Mic92 Mic92 force-pushed the tensorflow branch 2 times, most recently from 7d7963c to 6461be2 Compare August 10, 2022 07:28
@Mic92
python3.pkgs.tensorflow: 2.9.1 -> 2.10.0-rc0
161ea79 
python3.pkgs.tensorflow: 2.9.1 -> 2.10.0-rc0
@Mic92 Mic92 merged commit 9da3137 into NixOS:master Aug 10, 2022
@Mic92 Mic92 deleted the tensorflow branch August 10, 2022 07:29
@veprbl
Copy link
Member

veprbl commented Aug 10, 2022

Usually such those breakages can be addressed by fetching a patch from upstream.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@FRidh FRidh Awaiting requested review from FRidh

@jonringer jonringer Awaiting requested review from jonringer

@abbradar abbradar Awaiting requested review from abbradar

Assignees

No one assigned

Labels

6.topic: python Python is a high-level, general-purpose programming language. 10.rebuild-darwin: 11-100 This PR causes between 11 and 100 packages to rebuild on Darwin. 10.rebuild-linux: 11-100 This PR causes between 11 and 100 packages to rebuild on Linux.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@Mic92 @veprbl