Skip to content

zlib: add patch for CVE-2022-37434#185554

Merged
risicle merged 1 commit intoNixOS:stagingfrom
risicle:ris-zlib-CVE-2022-37434
Aug 7, 2022
Merged

zlib: add patch for CVE-2022-37434#185554
risicle merged 1 commit intoNixOS:stagingfrom
risicle:ris-zlib-CVE-2022-37434

Conversation

@risicle
Copy link
Contributor

@risicle risicle commented Aug 7, 2022

Description of changes

https://nvd.nist.gov/vuln/detail/CVE-2022-37434

Have personally tested the PoC is fixed by this patch.

Things done
  • Built on platform(s)
    • x86_64-linux
    • aarch64-linux
    • x86_64-darwin
    • aarch64-darwin
  • For non-Linux: Is sandbox = true set in nix.conf? (See Nix manual)
  • Tested, as applicable:
  • Tested compilation of all packages that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage
  • Tested basic functionality of all binary files (usually in ./result/bin/)
  • 22.11 Release Notes (or backporting 22.05 Release notes)
    • (Package updates) Added a release notes entry if the change is major or breaking
    • (Module updates) Added a release notes entry if the change is significant
    • (Module addition) Added a release notes entry if adding a new NixOS module
    • (Release notes changes) Ran nixos/doc/manual/md-to-db.sh to update generated release notes
  • Fits CONTRIBUTING.md.

@risicle risicle added 1.severity: security Issues which raise a security issue, or PRs that fix one backport staging-22.05 labels Aug 7, 2022
@ofborg ofborg bot added 10.rebuild-darwin-stdenv This PR causes stdenv to rebuild on Darwin and must target a staging branch. 10.rebuild-linux-stdenv This PR causes stdenv to rebuild on Linux and must target a staging branch. 10.rebuild-darwin: 501+ This PR causes many rebuilds on Darwin and should normally target the staging branches. 10.rebuild-darwin: 5001+ This PR causes many rebuilds on Darwin and must target the staging branches. 10.rebuild-linux: 501+ This PR causes many rebuilds on Linux and should normally target the staging branches. 10.rebuild-linux: 5001+ This PR causes many rebuilds on Linux and must target the staging branches. labels Aug 7, 2022
@risicle risicle merged commit 723332d into NixOS:staging Aug 7, 2022
@github-actions github-actions bot mentioned this pull request Aug 7, 2022
Closed
1 task
@github-actions
Copy link
Contributor

github-actions bot commented Aug 7, 2022

Successfully created backport PR #185578 for staging-22.05.

@risicle
Copy link
Contributor Author

risicle commented Aug 7, 2022

Considering reverting this due to issues found in #185578

@risicle risicle mentioned this pull request Aug 7, 2022
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@Lassulus Lassulus Lassulus approved these changes

@SuperSandro2000 SuperSandro2000 SuperSandro2000 approved these changes

Assignees

No one assigned

Labels

1.severity: security Issues which raise a security issue, or PRs that fix one 10.rebuild-darwin: 501+ This PR causes many rebuilds on Darwin and should normally target the staging branches. 10.rebuild-darwin: 5001+ This PR causes many rebuilds on Darwin and must target the staging branches. 10.rebuild-darwin-stdenv This PR causes stdenv to rebuild on Darwin and must target a staging branch. 10.rebuild-linux: 501+ This PR causes many rebuilds on Linux and should normally target the staging branches. 10.rebuild-linux: 5001+ This PR causes many rebuilds on Linux and must target the staging branches. 10.rebuild-linux-stdenv This PR causes stdenv to rebuild on Linux and must target a staging branch.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@risicle @Lassulus @SuperSandro2000