nixos/openldap: fix option description markdown#184902
Merged
pennae merged 1 commit intoNixOS:staging-nextfrom Aug 2, 2022
Merged
nixos/openldap: fix option description markdown#184902pennae merged 1 commit intoNixOS:staging-nextfrom
pennae merged 1 commit intoNixOS:staging-nextfrom
Conversation
github-actions
bot
added
6.topic: nixos
pennae
approved these changes
Aug 2, 2022
Contributor
|
yikes, that came in from an old place. just waiting for CI to merge. |
winterqt
requested changes
Aug 2, 2022
Member
winterqt
left a comment
winterqt
left a comment
There was a problem hiding this comment.
Nit (so feel free to not make this change), but can the commit message be updated to fit the guidelines, i.e. nixos/openldap: fix option description markdown or similar?
ofborg
bot
added
10.rebuild-darwin: 0
stigtsp
approved these changes
Aug 2, 2022
Otherwise manual build fails as:
$ nix build -f nixos/release.nix manual.x86_64-linux
...
> NotImplementedError: ('md node not supported yet', 'services.openldap.declarativeContents', 'inline_html', ('<code>',))
For full logs, run 'nix log /nix/store/pfa7bg3pflp0c31ma0rc2ahwqabs88dd-base-json-md-converted.drv'.
trofi
force-pushed
the
fix-openldap-markdown
branch
from
f22c868 to
1e8102c
Compare
trofi
changed the title
Contributor
Author
Sounds good! Updated. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Otherwise manual build fails as:
Description of changes
Things done
sandbox = trueset innix.conf? (See Nix manual)nix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage./result/bin/)nixos/doc/manual/md-to-db.shto update generated release notes