Skip to content

ntfy: pin older emoji#184418

Closed
peterhoeg wants to merge 1 commit intoNixOS:masterfrom
peterhoeg:f/ntfy
Closed

ntfy: pin older emoji#184418
peterhoeg wants to merge 1 commit intoNixOS:masterfrom
peterhoeg:f/ntfy

Conversation

@peterhoeg
Copy link
Member

Description of changes

emoji 2.0.0 introduces breaking changes, so pin an older version.

Further to 3920fde

Things done
  • Built on platform(s)
    • x86_64-linux
    • aarch64-linux
    • x86_64-darwin
    • aarch64-darwin
  • For non-Linux: Is sandbox = true set in nix.conf? (See Nix manual)
  • Tested, as applicable:
  • Tested compilation of all packages that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage
  • Tested basic functionality of all binary files (usually in ./result/bin/)
  • 22.11 Release Notes (or backporting 22.05 Release notes)
    • (Package updates) Added a release notes entry if the change is major or breaking
    • (Module updates) Added a release notes entry if the change is significant
    • (Module addition) Added a release notes entry if adding a new NixOS module
    • (Release notes changes) Ran nixos/doc/manual/md-to-db.sh to update generated release notes
  • Fits CONTRIBUTING.md.

@ofborg ofborg bot requested review from jfrankenau and kamilchm August 1, 2022 03:48
@ofborg ofborg bot added 10.rebuild-darwin: 1-10 This PR causes between 1 and 10 packages to rebuild on Darwin. 10.rebuild-darwin: 1 This PR causes 1 package to rebuild on Darwin. 10.rebuild-linux: 1-10 This PR causes between 1 and 10 packages to rebuild on Linux. 10.rebuild-linux: 1 This PR causes 1 package to rebuild on Linux. labels Aug 1, 2022
@austinbutler
Copy link
Member

@peterhoeg I noticed a PR that fixes the issue, and I figured using the patch is probably lighter than another version of emoji: #185088

@peterhoeg
Copy link
Member Author

In principle, we should wait for upstream to at least comment on the proposed fix (ideally it should be merged) before we choose to go in that direction but as the fix is a one-liner, it's definitely manageable.

@peterhoeg peterhoeg closed this Aug 4, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

10.rebuild-darwin: 1-10 This PR causes between 1 and 10 packages to rebuild on Darwin. 10.rebuild-darwin: 1 This PR causes 1 package to rebuild on Darwin. 10.rebuild-linux: 1-10 This PR causes between 1 and 10 packages to rebuild on Linux. 10.rebuild-linux: 1 This PR causes 1 package to rebuild on Linux.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants