bintools-wrapper, cc-wrapper: avoid invalid export of 'expand-respons…#184251
Merged
trofi merged 1 commit intoNixOS:stagingfrom Aug 6, 2022
Merged
bintools-wrapper, cc-wrapper: avoid invalid export of 'expand-respons…#184251trofi merged 1 commit intoNixOS:stagingfrom
trofi merged 1 commit intoNixOS:stagingfrom
Conversation
…e-params' POSIX sh (and `bash`) impose a restriction on environment variable name format and disallow hypheps in the names. Normally it's not a problem as nothing usually tries to refer nyphenated names. One exception is `nix develop` (NixOS/nix#6848): $ nix develop -f. gcc -L gcc-wrapper> ...-get-env.sh: line 70: expand-response-params: bad substitution Note that bash usually uses explicitly created `expandResponseParams` variant of the same variable. To work the problem around let's avoid environment variable export and move it to `passthru` for `cc` (used ina few places) and remove it completely for `binutils` (does not seem to be used at all).
ofborg
bot
added
10.rebuild-darwin-stdenv
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
…e-params'
POSIX sh (and
bash) impose a restriction on environment variable nameformat and disallow hypheps in the names. Normally it's not a problem
as nothing usually tries to refer nyphenated names.
One exception is
nix develop(NixOS/nix#6848):Note that bash usually uses explicitly created
expandResponseParamsvariant of the same variable.
To work the problem around let's avoid environment variable export and move
it to
passthruforcc(used ina few places) and remove it completely forbinutils(does not seem to be used at all).Description of changes
Things done
sandbox = trueset innix.conf? (See Nix manual)nix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage./result/bin/)nixos/doc/manual/md-to-db.shto update generated release notes