Skip to content

vte, gnome-console: add darwin support#183352

Merged
SuperSandro2000 merged 2 commits intoNixOS:masterfrom
wegank:vte-darwin
Aug 1, 2022
Merged

vte, gnome-console: add darwin support#183352
SuperSandro2000 merged 2 commits intoNixOS:masterfrom
wegank:vte-darwin

Conversation

@wegank
Copy link
Member

@wegank wegank commented Jul 28, 2022 •
edited
Loading

Description of changes

As in the title.

Things done
  • Built on platform(s)
    • x86_64-linux
    • aarch64-linux
    • x86_64-darwin
    • aarch64-darwin
  • For non-Linux: Is sandbox = true set in nix.conf? (See Nix manual)
  • Tested, as applicable:
  • Tested compilation of all packages that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage
  • Tested basic functionality of all binary files (usually in ./result/bin/)
  • 22.11 Release Notes (or backporting 22.05 Release notes)
    • (Package updates) Added a release notes entry if the change is major or breaking
    • (Module updates) Added a release notes entry if the change is significant
    • (Module addition) Added a release notes entry if adding a new NixOS module
    • (Release notes changes) Ran nixos/doc/manual/md-to-db.sh to update generated release notes
  • Fits CONTRIBUTING.md.

@ofborg ofborg bot added the 6.topic: darwin Running or building packages on Darwin label Jul 28, 2022
@ofborg ofborg bot added 10.rebuild-darwin: 1-10 This PR causes between 1 and 10 packages to rebuild on Darwin. 10.rebuild-linux: 0 This PR does not cause any packages to rebuild on Linux. labels Jul 28, 2022
@smancill
Copy link
Contributor

smancill commented Jul 29, 2022

Result of nixpkgs-review pr 183352 run on x86_64-darwin 1

3 packages marked as broken and skipped:
  • appvm
  • mate.caja-extensions
  • mate.mate-terminal
5 packages built:
  • germinal
  • gtkd
  • kermit-terminal
  • termite (termite-unwrapped)
  • vte

@nixos-discourse
Copy link

nixos-discourse commented Jul 30, 2022

This pull request has been mentioned on NixOS Discourse. There might be relevant details there:

https://discourse.nixos.org/t/prs-ready-for-review/3032/1047

SuperSandro2000
SuperSandro2000 reviewed Jul 30, 2022
View reviewed changes
@wegank wegank requested a review from SuperSandro2000 July 30, 2022 21:07
@wegank wegank changed the title vte: fix build on darwin vte, gnome-console: add darwin support Jul 31, 2022
@ofborg ofborg bot added the 8.has: package (new) This PR adds a new package label Jul 31, 2022
@ofborg ofborg bot requested a review from zhaofengli July 31, 2022 18:42
@ofborg ofborg bot added 10.rebuild-linux: 1-10 This PR causes between 1 and 10 packages to rebuild on Linux. 10.rebuild-linux: 1 This PR causes 1 package to rebuild on Linux. and removed 10.rebuild-linux: 0 This PR does not cause any packages to rebuild on Linux. labels Jul 31, 2022
@nixos-discourse
Copy link

nixos-discourse commented Aug 1, 2022

This pull request has been mentioned on NixOS Discourse. There might be relevant details there:

https://discourse.nixos.org/t/prs-ready-for-review/3032/1055

@wegank wegank requested a review from SuperSandro2000 August 1, 2022 13:07
@SuperSandro2000 SuperSandro2000 merged commit 85f8f07 into NixOS:master Aug 1, 2022
@wegank wegank deleted the vte-darwin branch August 2, 2022 01:22
@wegank wegank mentioned this pull request Aug 31, 2022
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@amaxine amaxine Awaiting requested review from amaxine

@astsmtl astsmtl Awaiting requested review from astsmtl

@bobby285271 bobby285271 Awaiting requested review from bobby285271

@dasj19 dasj19 Awaiting requested review from dasj19

@jtojnar jtojnar Awaiting requested review from jtojnar

@hedning hedning Awaiting requested review from hedning

@zhaofengli zhaofengli Awaiting requested review from zhaofengli

@SuperSandro2000 SuperSandro2000 Awaiting requested review from SuperSandro2000

Assignees

No one assigned

Labels

6.topic: darwin Running or building packages on Darwin 8.has: package (new) This PR adds a new package 10.rebuild-darwin: 1-10 This PR causes between 1 and 10 packages to rebuild on Darwin. 10.rebuild-linux: 1-10 This PR causes between 1 and 10 packages to rebuild on Linux. 10.rebuild-linux: 1 This PR causes 1 package to rebuild on Linux.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@wegank @smancill @nixos-discourse @SuperSandro2000