haskellPackages.levenshtein: disable tests and unbreak#183151
Closed
phijor wants to merge 1 commit intoNixOS:haskell-updatesfrom
Closed
haskellPackages.levenshtein: disable tests and unbreak#183151phijor wants to merge 1 commit intoNixOS:haskell-updatesfrom
phijor wants to merge 1 commit intoNixOS:haskell-updatesfrom
Conversation
Member
|
Since a new version with the fix was released, I think the change will actually be simpler, we just need to remove the broken flag the next time we update the haskell package set. We can keep this PR open to remind us for now. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description of changes
Disable the test suite for
haskellPackages.levenshteinsince it fails with GHC 9.An issue (hapytex/levenshtein/issues/9) was raised with upstream.
This is my first time contributing to Nix, so I am happy to take any feedback or guidance.
Things done
sandbox = trueset innix.conf? (See Nix manual)nix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage./result/bin/)nixos/doc/manual/md-to-db.shto update generated release notes