Skip to content

vimPlugins: Add mason-{nvim,lspconfig-nvim,tool-installer-nvim}#183115

Merged
teto merged 3 commits intoNixOS:masterfrom
pyrox0:mason-nvim-init
Jan 4, 2023
Merged

vimPlugins: Add mason-{nvim,lspconfig-nvim,tool-installer-nvim}#183115
teto merged 3 commits intoNixOS:masterfrom
pyrox0:mason-nvim-init

Conversation

@pyrox0
Copy link
Copy Markdown
Member

@pyrox0 pyrox0 commented Jul 27, 2022

Description of changes

Adds the mason-nvim, mason-lspconfig-nvim, and mason-tool-installer-nvim plugins.

Things done
  • Built on platform(s)
    • x86_64-linux
    • aarch64-linux
    • x86_64-darwin
    • aarch64-darwin
  • For non-Linux: Is sandbox = true set in nix.conf? (See Nix manual)
  • Tested, as applicable:
  • Tested compilation of all packages that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage
  • Tested basic functionality of all binary files (usually in ./result/bin/)
  • 22.11 Release Notes (or backporting 22.05 Release notes)
    • (Package updates) Added a release notes entry if the change is major or breaking
    • (Module updates) Added a release notes entry if the change is significant
    • (Module addition) Added a release notes entry if adding a new NixOS module
    • (Release notes changes) Ran nixos/doc/manual/md-to-db.sh to update generated release notes
  • Fits CONTRIBUTING.md.

@pyrox0 pyrox0 requested a review from jonringer as a code owner July 27, 2022 16:26
@github-actions github-actions bot added the 6.topic: vim Advanced text editor label Jul 27, 2022
@pyrox0
Copy link
Copy Markdown
Member Author

pyrox0 commented Jul 27, 2022

Result of nixpkgs-review pr 183115 run on x86_64-linux 1

1 package marked as broken and skipped:
  • vimPlugins.fugitive
11 packages built:
  • spacevim
  • vimPlugins.fzf-lua
  • vimPlugins.luasnip
  • vimPlugins.mason-lspconfig-nvim
  • vimPlugins.mason-nvim
  • vimPlugins.mason-tool-installer-nvim
  • vimPlugins.nui-nvim
  • vimPlugins.nvim-lint
  • vimPlugins.nvim-tree-lua
  • vimPlugins.vim-clap
  • vimPlugins.vim-fugitive

@ofborg ofborg bot added 8.has: package (new) This PR adds a new package 10.rebuild-darwin: 1-10 This PR causes between 1 and 10 packages to rebuild on Darwin. 10.rebuild-linux: 11-100 This PR causes between 11 and 100 packages to rebuild on Linux. labels Jul 27, 2022
@pyrox0
Copy link
Copy Markdown
Member Author

pyrox0 commented Aug 3, 2022

This is ready to merge.

@teto
Copy link
Copy Markdown
Member

teto commented Aug 29, 2022

can you rebase and run a nixpkgs-review on it please ? if you want it to be merged fastly, you can drop the general update commit.

@teto
Copy link
Copy Markdown
Member

teto commented Dec 28, 2022

ping :) ?

@pyrox0 pyrox0 requested a review from figsoda as a code owner January 3, 2023 23:50
@ofborg ofborg bot added 10.rebuild-linux: 1-10 This PR causes between 1 and 10 packages to rebuild on Linux. and removed 10.rebuild-linux: 11-100 This PR causes between 11 and 100 packages to rebuild on Linux. labels Jan 4, 2023
@figsoda
Copy link
Copy Markdown
Member

figsoda commented Jan 4, 2023

please change your commit messages to

vimPlugins.mason-nvim: init at 2022-07-27
vimPlugins.mason-tool-installer.nvim: init at 2022-07-26
vimPlugins.mason-lspconfig-nvim: init at 2022-07-25

@pyrox0
Copy link
Copy Markdown
Member Author

pyrox0 commented Jan 4, 2023

please change your commit messages to

vimPlugins.mason-nvim: init at 2022-07-27
vimPlugins.mason-tool-installer.nvim: init at 2022-07-26
vimPlugins.mason-lspconfig-nvim: init at 2022-07-25

Just updated the names for the 2nd and 3rd commits. I don't think I need to change the name for the first.

@teto
Copy link
Copy Markdown
Member

teto commented Jan 4, 2023

plugin-specific overrides belong to the init commit, it doesn't make sense to have them in a separate commit (makes revert harder etc) but let's not spend too much time on this. Merging (you will know for your next vim plugin PR ;) )

@teto teto merged commit 05968fc into NixOS:master Jan 4, 2023
@pyrox0 pyrox0 deleted the mason-nvim-init branch April 24, 2024 04:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

6.topic: vim Advanced text editor 8.has: package (new) This PR adds a new package 10.rebuild-darwin: 1-10 This PR causes between 1 and 10 packages to rebuild on Darwin. 10.rebuild-linux: 1-10 This PR causes between 1 and 10 packages to rebuild on Linux.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants