vimPlugins: Add mason-{nvim,lspconfig-nvim,tool-installer-nvim}#183115
Merged
teto merged 3 commits intoNixOS:masterfrom Jan 4, 2023
Merged
vimPlugins: Add mason-{nvim,lspconfig-nvim,tool-installer-nvim}#183115teto merged 3 commits intoNixOS:masterfrom
teto merged 3 commits intoNixOS:masterfrom
Conversation
Member
Author
|
Result of 1 package marked as broken and skipped:
11 packages built:
|
Member
Author
|
This is ready to merge. |
Member
|
can you rebase and run a nixpkgs-review on it please ? if you want it to be merged fastly, you can drop the general update commit. |
Member
|
ping :) ? |
ddbbc1c to
1ef3c38
Compare
figsoda
reviewed
Jan 4, 2023
teto
reviewed
Jan 4, 2023
1ef3c38 to
b136e96
Compare
b136e96 to
4315132
Compare
Member
|
please change your commit messages to |
vimPlugins.mason-lspconfig-nvim: init at 2022-07-25
…ason-lspconfig-nvim
4315132 to
bc7d5ce
Compare
Member
Author
Just updated the names for the 2nd and 3rd commits. I don't think I need to change the name for the first. |
Member
|
plugin-specific overrides belong to the init commit, it doesn't make sense to have them in a separate commit (makes revert harder etc) but let's not spend too much time on this. Merging (you will know for your next vim plugin PR ;) ) |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description of changes
Adds the mason-nvim, mason-lspconfig-nvim, and mason-tool-installer-nvim plugins.
Things done
sandbox = trueset innix.conf? (See Nix manual)nix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage./result/bin/)nixos/doc/manual/md-to-db.shto update generated release notes