pciutils, ntfs3g: don't pull in kmod on darwin#182720
Merged
SuperSandro2000 merged 1 commit intoNixOS:stagingfrom Jul 25, 2022
Merged
pciutils, ntfs3g: don't pull in kmod on darwin#182720SuperSandro2000 merged 1 commit intoNixOS:stagingfrom
kmod on darwin#182720SuperSandro2000 merged 1 commit intoNixOS:stagingfrom
Conversation
ofborg
bot
added
10.rebuild-darwin: 101-500
Artturin
reviewed
Jul 24, 2022
Artturin
reviewed
Jul 24, 2022
trofi
force-pushed
the
drop-kmod-on-darwin
branch
from
d0b44be to
a5c3e0a
Compare
ofborg
bot
added
10.rebuild-linux: 501+
`kmod` is a linux-only package. Previous versions worked on `darwin` by chance and might break in the future. Remove `kmod` import from there. Co-authored-by: Artturi <Artturin@artturin.com>
trofi
force-pushed
the
drop-kmod-on-darwin
branch
from
a5c3e0a to
ab4d64d
Compare
trofi
added a commit
to trofi/nixpkgs
that referenced
this pull request
Jul 25, 2022
commit 7a2c07d "kmod: enable on darwin" added darwin support mostly for `depmod` to be able to build `linux` kernel on `darwin`. In version 30 kmod requires more and more linux syscalls to build. Instead of patching it for darwin let's drop it's support instead. Maybe `depmod` could be packaged using some other way if needed. Related: NixOS#182720 removed `kmod` use on `darwin` from rare packages that still pulled it in.
Artturin
pushed a commit
to Artturin/nixpkgs
that referenced
this pull request
Jul 27, 2022
commit 7a2c07d "kmod: enable on darwin" added darwin support mostly for `depmod` to be able to build `linux` kernel on `darwin`. In version 30 kmod requires more and more linux syscalls to build. Instead of patching it for darwin let's drop it's support instead. Maybe `depmod` could be packaged using some other way if needed. Related: NixOS#182720 removed `kmod` use on `darwin` from rare packages that still pulled it in.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
kmodis a linux-only package. Previous versions worked ondarwinby chance and might break in the future:
#182714
Remove
kmodimport from there.Description of changes
Things done
sandbox = trueset innix.conf? (See Nix manual)nix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage./result/bin/)nixos/doc/manual/md-to-db.shto update generated release notes