Skip to content

[Backport release-22.05] JabRef: 5.5 -> 5.6#182633

Merged
Mindavi merged 2 commits intoNixOS:release-22.05from
fleimgruber:backport_jabref_5_6
Jul 27, 2022
Merged

[Backport release-22.05] JabRef: 5.5 -> 5.6#182633
Mindavi merged 2 commits intoNixOS:release-22.05from
fleimgruber:backport_jabref_5_6

Conversation

@fleimgruber
Copy link
Contributor

@fleimgruber fleimgruber commented Jul 23, 2022

(cherry picked from commit 2df7e18)

See also #182065 (comment) and #162593.

Description of changes
Things done
  • Built on platform(s)
    • x86_64-linux
    • aarch64-linux
    • x86_64-darwin
    • aarch64-darwin
  • For non-Linux: Is sandbox = true set in nix.conf? (See Nix manual)
  • Tested, as applicable:
  • Tested compilation of all packages that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage
  • Tested basic functionality of all binary files (usually in ./result/bin/)
  • 22.11 Release Notes (or backporting 22.05 Release notes)
    • (Package updates) Added a release notes entry if the change is major or breaking
    • (Module updates) Added a release notes entry if the change is significant
    • (Module addition) Added a release notes entry if adding a new NixOS module
    • (Release notes changes) Ran nixos/doc/manual/md-to-db.sh to update generated release notes
  • Fits CONTRIBUTING.md.

@fleimgruber
JabRef: 5.5 -> 5.6
5ba4dff 
(cherry picked from commit 2df7e18)
bobby285271
bobby285271 reviewed Jul 24, 2022
View reviewed changes
@ofborg ofborg bot added the 8.has: clean-up This PR removes packages or removes other cruft label Jul 24, 2022
@ofborg ofborg bot requested review from gebner and linsui July 24, 2022 08:31
@ofborg ofborg bot added 10.rebuild-darwin: 0 This PR does not cause any packages to rebuild on Darwin. 10.rebuild-linux: 1-10 This PR causes between 1 and 10 packages to rebuild on Linux. 10.rebuild-linux: 1 This PR causes 1 package to rebuild on Linux. labels Jul 24, 2022
@wamserma
Copy link
Member

wamserma commented Jul 27, 2022

@SuperSandro2000 ping 4 merge

@bobby285271 bobby285271 added 12.approvals: 2 This PR was reviewed and approved by two persons. 12.approved-by: package-maintainer This PR was reviewed and approved by a maintainer listed in any of the changed packages. labels Jul 27, 2022
@Mindavi Mindavi merged commit 76e5467 into NixOS:release-22.05 Jul 27, 2022
@fleimgruber fleimgruber deleted the backport_jabref_5_6 branch July 28, 2022 12:09
@fleimgruber fleimgruber mentioned this pull request Jul 26, 2023
Merged
1 task
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@bobby285271 bobby285271 bobby285271 left review comments

@gebner gebner Awaiting requested review from gebner

+2 more reviewers

@wamserma wamserma wamserma approved these changes

@linsui linsui linsui approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

8.has: clean-up This PR removes packages or removes other cruft 10.rebuild-darwin: 0 This PR does not cause any packages to rebuild on Darwin. 10.rebuild-linux: 1-10 This PR causes between 1 and 10 packages to rebuild on Linux. 10.rebuild-linux: 1 This PR causes 1 package to rebuild on Linux. 12.approvals: 2 This PR was reviewed and approved by two persons. 12.approved-by: package-maintainer This PR was reviewed and approved by a maintainer listed in any of the changed packages.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

5 participants

@fleimgruber @wamserma @bobby285271 @linsui @Mindavi