Skip to content

Update and refactor UT2004#18259

Merged
abbradar merged 2 commits intoNixOS:masterfrom
abbradar:ut2004
Sep 17, 2016
Merged

Update and refactor UT2004#18259
abbradar merged 2 commits intoNixOS:masterfrom
abbradar:ut2004

Conversation

@abbradar
Copy link
Copy Markdown
Member

@abbradar abbradar commented Sep 3, 2016

Motivation for this change

Update the game to the latest demo version and allow to use full game resources if available.

Things done
  • Tested using sandboxing
    (nix.useSandbox on NixOS,
    or option build-use-sandbox in nix.conf
    on non-NixOS)
  • Built on platform(s)
    • NixOS
    • OS X
    • Linux
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nox --run "nox-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Fits CONTRIBUTING.md.

With this one can build ut2004Packages.ut2004 [ fullGame latestPatch ] and play the full game. I have expressions for both the full game (for GOG version) and the latest patch but as per #10981 we don't want to include packages that require paid data files. I think of publishing them in a separate repo later along with several other packages like this.

Merging in several days unless someone spots a problem.

@abbradar abbradar added the 8.has: package (update) This PR updates a package to a newer version label Sep 3, 2016
@mention-bot
Copy link
Copy Markdown

@abbradar, thanks for your PR! By analyzing the annotation information on this pull request, we identified @edolstra, @vcunat and @robberer to be potential reviewers

@abbradar abbradar merged commit d997f45 into NixOS:master Sep 17, 2016
@abbradar
Copy link
Copy Markdown
Member Author

For those interested, I have a small repository with several games that don't belong to nixpkgs: https://github.com/abbradar/nixpkgs-nonfree. For now I only have ut2004 and nwn here.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

8.has: package (update) This PR updates a package to a newer version

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants