Skip to content

treewide: fix fallout from 'cmake/setup-hook.sh: Don't skip build-RPATH'#181540

Merged
SuperSandro2000 merged 1 commit intoNixOS:staging-nextfrom
Artturin:rpathfixes2
Jul 15, 2022
Merged

treewide: fix fallout from 'cmake/setup-hook.sh: Don't skip build-RPATH'#181540
SuperSandro2000 merged 1 commit intoNixOS:staging-nextfrom
Artturin:rpathfixes2

Conversation

@Artturin
Copy link
Member

@Artturin Artturin commented Jul 14, 2022

f7414e2

Description of changes
Things done
  • Built on platform(s)
    • x86_64-linux
    • aarch64-linux
    • x86_64-darwin
    • aarch64-darwin
  • For non-Linux: Is sandbox = true set in nix.conf? (See Nix manual)
  • Tested, as applicable:
  • Tested compilation of all packages that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage
  • Tested basic functionality of all binary files (usually in ./result/bin/)
  • 22.11 Release Notes (or backporting 22.05 Release notes)
    • (Package updates) Added a release notes entry if the change is major or breaking
    • (Module updates) Added a release notes entry if the change is significant
    • (Module addition) Added a release notes entry if adding a new NixOS module
    • (Release notes changes) Ran nixos/doc/manual/md-to-db.sh to update generated release notes
  • Fits CONTRIBUTING.md.

This was referenced Jul 14, 2022
Merged
Closed
@ofborg ofborg bot added 10.rebuild-darwin: 11-100 This PR causes between 11 and 100 packages to rebuild on Darwin. 10.rebuild-linux: 101-500 This PR causes between 101 and 500 packages to rebuild on Linux. labels Jul 15, 2022
@SuperSandro2000 SuperSandro2000 merged commit 0405b0f into NixOS:staging-next Jul 15, 2022
@Artturin Artturin deleted the rpathfixes2 branch July 15, 2022 11:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@bjornfor bjornfor bjornfor approved these changes

@acairncross acairncross Awaiting requested review from acairncross

@oxij oxij Awaiting requested review from oxij

@erdnaxe erdnaxe Awaiting requested review from erdnaxe

@wucke13 wucke13 Awaiting requested review from wucke13

@elitak elitak Awaiting requested review from elitak

@mickours mickours Awaiting requested review from mickours

@lopsided98 lopsided98 Awaiting requested review from lopsided98

@sikmir sikmir Awaiting requested review from sikmir

@mpoquet mpoquet Awaiting requested review from mpoquet

+1 more reviewer

@trofi trofi trofi approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

10.rebuild-darwin: 11-100 This PR causes between 11 and 100 packages to rebuild on Darwin. 10.rebuild-linux: 101-500 This PR causes between 101 and 500 packages to rebuild on Linux.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

5 participants

@Artturin @bjornfor @trofi @vcunat @SuperSandro2000

Comments