Skip to content

python3Packages.rich: add some key reverse dependencies to passthru.tests#181503

Merged
SuperSandro2000 merged 1 commit intoNixOS:masterfrom
risicle:ris-rich-passthru-tests
Aug 14, 2022
Merged

python3Packages.rich: add some key reverse dependencies to passthru.tests#181503
SuperSandro2000 merged 1 commit intoNixOS:masterfrom
risicle:ris-rich-passthru-tests

Conversation

@risicle
Copy link
Contributor

@risicle risicle commented Jul 14, 2022

Description of changes

rich has too many reverse dependencies to test through nixpkgs-review sensibly, so choosing a small selection of these for suggested testing targets is often useful.

Things done
  • Built on platform(s)
    • x86_64-linux
    • aarch64-linux
    • x86_64-darwin
    • aarch64-darwin
  • For non-Linux: Is sandbox = true set in nix.conf? (See Nix manual)
  • Tested, as applicable:
  • Tested compilation of all packages that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage
  • Tested basic functionality of all binary files (usually in ./result/bin/)
  • 22.11 Release Notes (or backporting 22.05 Release notes)
    • (Package updates) Added a release notes entry if the change is major or breaking
    • (Module updates) Added a release notes entry if the change is significant
    • (Module addition) Added a release notes entry if adding a new NixOS module
    • (Release notes changes) Ran nixos/doc/manual/md-to-db.sh to update generated release notes
  • Fits CONTRIBUTING.md.

@risicle risicle requested review from FRidh and jonringer as code owners July 14, 2022 19:27
@github-actions github-actions bot added the 6.topic: python Python is a high-level, general-purpose programming language. label Jul 14, 2022
@ofborg ofborg bot added 10.rebuild-darwin: 0 This PR does not cause any packages to rebuild on Darwin. 10.rebuild-linux: 0 This PR does not cause any packages to rebuild on Linux. labels Jul 14, 2022
@SuperSandro2000 SuperSandro2000 merged commit d6fc042 into NixOS:master Aug 14, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

6.topic: python Python is a high-level, general-purpose programming language. 10.rebuild-darwin: 0 This PR does not cause any packages to rebuild on Darwin. 10.rebuild-linux: 0 This PR does not cause any packages to rebuild on Linux.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants