Skip to content

Comments

wkhtmltopdf: unbreak on darwin#180669

Merged
SuperSandro2000 merged 1 commit intoNixOS:masterfrom
jiegec:wkhtmltopdf
Jul 13, 2022
Merged

wkhtmltopdf: unbreak on darwin#180669
SuperSandro2000 merged 1 commit intoNixOS:masterfrom
jiegec:wkhtmltopdf

Conversation

@jiegec
Copy link
Member

@jiegec jiegec commented Jul 8, 2022

Description of changes

Unbreak wkhtmltopdf on darwin by changing dylib paths.

Fixes issue #11861.

Things done
  • Built on platform(s)
    • x86_64-linux
    • aarch64-linux
    • x86_64-darwin
    • aarch64-darwin
  • For non-Linux: Is sandbox = true set in nix.conf? (See Nix manual)
  • Tested, as applicable:
  • Tested compilation of all packages that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage
  • Tested basic functionality of all binary files (usually in ./result/bin/)
  • 22.11 Release Notes (or backporting 22.05 Release notes)
    • (Package updates) Added a release notes entry if the change is major or breaking
    • (Module updates) Added a release notes entry if the change is significant
    • (Module addition) Added a release notes entry if adding a new NixOS module
    • (Release notes changes) Ran nixos/doc/manual/md-to-db.sh to update generated release notes
  • Fits CONTRIBUTING.md.

@ofborg ofborg bot added 6.topic: darwin Running or building packages on Darwin 8.has: package (new) This PR adds a new package labels Jul 8, 2022
@ofborg ofborg bot requested a review from jb55 July 8, 2022 09:11
@ofborg ofborg bot added 10.rebuild-darwin: 1-10 This PR causes between 1 and 10 packages to rebuild on Darwin. 10.rebuild-linux: 1-10 This PR causes between 1 and 10 packages to rebuild on Linux. labels Jul 8, 2022
@jiegec
Copy link
Member Author

jiegec commented Jul 8, 2022

Result of nixpkgs-review pr 180669 run on x86_64-darwin 1

2 packages built:
  • odoo
  • wkhtmltopdf

Unbreak wkhtmltopdf on darwin by changing dylib paths.

Fixes issue NixOS#11861.
@siraben
Copy link
Member

siraben commented Jul 13, 2022

Result of nixpkgs-review pr 180669 run on aarch64-darwin 1

2 packages marked as broken and skipped:
  • odoo
  • wkhtmltopdf

@jiegec
Copy link
Member Author

jiegec commented Jul 13, 2022

Result of nixpkgs-review pr 180669 run on aarch64-darwin 1

2 packages marked as broken and skipped:

  • odoo
  • wkhtmltopdf

This is due to qt broken, will be fixed by #180327.

@SuperSandro2000 SuperSandro2000 merged commit 2d741d2 into NixOS:master Jul 13, 2022
@jiegec jiegec deleted the wkhtmltopdf branch July 13, 2022 10:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

6.topic: darwin Running or building packages on Darwin 8.has: package (new) This PR adds a new package 10.rebuild-darwin: 1-10 This PR causes between 1 and 10 packages to rebuild on Darwin. 10.rebuild-linux: 1-10 This PR causes between 1 and 10 packages to rebuild on Linux.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants