Skip to content

python310Packages.google-auth: Fix tests after removing pyopenssl#180301

Merged
SuperSandro2000 merged 2 commits intoNixOS:staging-nextfrom
azuwis:google-auth
Jul 6, 2022
Merged

python310Packages.google-auth: Fix tests after removing pyopenssl#180301
SuperSandro2000 merged 2 commits intoNixOS:staging-nextfrom
azuwis:google-auth

Conversation

@azuwis
Copy link
Contributor

@azuwis azuwis commented Jul 6, 2022

Description of changes

See https://hydra.nixos.org/build/182833696/nixlog/1

Things done
  • Built on platform(s)
    • x86_64-linux
    • aarch64-linux
    • x86_64-darwin
    • aarch64-darwin
  • For non-Linux: Is sandbox = true set in nix.conf? (See Nix manual)
  • Tested, as applicable:
  • Tested compilation of all packages that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage
  • Tested basic functionality of all binary files (usually in ./result/bin/)
  • 22.11 Release Notes (or backporting 22.05 Release notes)
    • (Package updates) Added a release notes entry if the change is major or breaking
    • (Module updates) Added a release notes entry if the change is significant
    • (Module addition) Added a release notes entry if adding a new NixOS module
    • (Release notes changes) Ran nixos/doc/manual/md-to-db.sh to update generated release notes
  • Fits CONTRIBUTING.md.

@azuwis azuwis requested review from FRidh and jonringer as code owners July 6, 2022 03:02
@github-actions github-actions bot added the 6.topic: python Python is a high-level, general-purpose programming language. label Jul 6, 2022
@ofborg ofborg bot requested a review from SuperSandro2000 July 6, 2022 03:10
@ofborg ofborg bot added 10.rebuild-darwin: 101-500 This PR causes between 101 and 500 packages to rebuild on Darwin. 10.rebuild-linux: 101-500 This PR causes between 101 and 500 packages to rebuild on Linux. labels Jul 6, 2022
@azuwis azuwis mentioned this pull request Jul 6, 2022
Merged
@vcunat vcunat changed the base branch from master to staging-next July 6, 2022 07:04
@vcunat
Copy link
Member

vcunat commented Jul 6, 2022

As the build regression only appear on the staging-next branch so far, I'll assume that the fix should also be targeted there.

@ofborg build python3Packages.google-auth

SuperSandro2000
SuperSandro2000 reviewed Jul 6, 2022
View reviewed changes
@ofborg ofborg bot requested a review from SuperSandro2000 July 6, 2022 14:04
@SuperSandro2000
Copy link
Member

SuperSandro2000 commented Jul 6, 2022

Please prefix packages correct.

@ofborg build python310Packages.google-auth

@SuperSandro2000 SuperSandro2000 changed the title google-auth: Fix tests after removing pyopenssl python310Packages.google-auth: Fix tests after removing pyopenssl Jul 6, 2022
@SuperSandro2000 SuperSandro2000 merged commit be9b19d into NixOS:staging-next Jul 6, 2022
@azuwis azuwis deleted the google-auth branch July 9, 2022 20:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@FRidh FRidh Awaiting requested review from FRidh

@jonringer jonringer Awaiting requested review from jonringer

@SuperSandro2000 SuperSandro2000 Awaiting requested review from SuperSandro2000

Assignees

No one assigned

Labels

6.topic: python Python is a high-level, general-purpose programming language. 10.rebuild-darwin: 101-500 This PR causes between 101 and 500 packages to rebuild on Darwin. 10.rebuild-linux: 101-500 This PR causes between 101 and 500 packages to rebuild on Linux.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@azuwis @vcunat @SuperSandro2000