bun: init at 0.1.1

[DAlperin]

Description of changes

Add a package for https://bun.sh

Things done

• Built on platform(s)
  • x86_64-linux
  • aarch64-linux
  • x86_64-darwin
  • aarch64-darwin
• For non-Linux: Is sandbox = true set in nix.conf? (See Nix manual)
• Tested, as applicable:
  • NixOS test(s) (look inside nixos/tests)
  • and/or package tests
  • or, for functions and "core" functionality, tests in lib/tests or pkgs/test
  • made sure NixOS tests are linked to the relevant packages
• Tested compilation of all packages that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage
• Tested basic functionality of all binary files (usually in ./result/bin/)
• 22.11 Release Notes (or backporting 22.05 Release notes)
  • (Package updates) Added a release notes entry if the change is major or breaking
  • (Module updates) Added a release notes entry if the change is significant
  • (Module addition) Added a release notes entry if adding a new NixOS module
  • (Release notes changes) Ran nixos/doc/manual/md-to-db.sh to update generated release notes
• Fits CONTRIBUTING.md.

[DAlperin]

Alright @sudosubin that should do it I think

[Kranzes]

Why are we not building this from source?

[DAlperin]

For one, the nature of bun makes that very difficult to do. But besides that zig on Darwin is broken which would make that impossible to build for now. Additionally @sudosubin pointed out:

And bun uses patched webkit on linux during the build by zig, and produces cross-platform outputs. I'm not sure the webkit can be built on darwin with nix.

[DAlperin]

It's probably possible and a good idea to get it building under nix but I think that would be a not insignificant undertaking over a not insignificant amount of time.

[06kellyjac]

Yeah I've been playing with a source build and it's a bit of a faff

[06kellyjac]

the vast majority of this looks shared across darwin and linux

[DAlperin]

Alrighty folks, hows this?

[06kellyjac]

Looking very good. I'd advise a handful of minor tweaks

[leap0x7b]

Can't you just build it from source instead of just downloading the binaries from GitHub releases?

[DAlperin]

@leapofazzam123, this was discussed previously in the resolved convos in the thread. TL;DR: it is extremely complex and difficult to build, nix doesn't have the ability to build it native on darwin right now (zig is marked broken on darwin), and the build relies on cross compilation in a way that does not lend itself to being built from source right now. Thusly @06kellyjac @sudosubin myself and other decided it was best to use the binaries for now.

[06kellyjac]

Yeah. We can always swap to a source build once we get it working but it is a mess getting all the pieces together

[VergeDX]

Should we use the bun-bin pname until someone build it from source?

[DAlperin]

Personally I think that makes things more confusing then necessary for people looking for the bun package. Bun is a new project that will take some real for it's build system etc to get more polished. Once it becomes more possible down the line, I don't think it's that big of a deal to rewrite the derivation, but again I think it might be a bit before that's even possible and or reasonable.

[06kellyjac]

I dont think there's much of a standard here. I think the source provenance marking it as a binary is fine for now 🤷

[06kellyjac]

@lucasew 's suggestions plus a license tweak

diff --git a/pkgs/development/web/bun/default.nix b/pkgs/development/web/bun/default.nix
index 1a9c16d587b..04124379b14 100644
--- a/pkgs/development/web/bun/default.nix
+++ b/pkgs/development/web/bun/default.nix
@@ -30,16 +30,16 @@ stdenvNoCC.mkDerivation rec {
     sha256 = dist.sha256;
   };
 
-  sourceRoot = ".";
-  unpackCmd = "unzip bun-${dist.shortName}-${dist.arch}.zip";
+  strictDeps = true;
+  nativeBuildInputs = [ unzip ] ++ lib.optionals stdenvNoCC.isLinux [ autoPatchelfHook ];
+  buildInputs = [ openssl ];
+
   dontConfigure = true;
   dontBuild = true;
-  nativeBuildInputs = if stdenvNoCC.isLinux then [ autoPatchelfHook ] else [];
-  buildInputs = [ unzip openssl ];
 
   installPhase = ''
     runHook preInstall
-    install -Dm 755 ./bun-${dist.shortName}-${dist.arch}/bun $out/bin
+    install -Dm 755 ./bun $out/bin/bun
     runHook postInstall
   '';
 
@@ -52,8 +52,8 @@ stdenvNoCC.mkDerivation rec {
       All in one fast & easy-to-use tool. Instead of 1,000 node_modules for development, you only need bun.
     '';
     license = with licenses; [
-      mit #bun core
-      lgpl2 #javascriptcore and webkit
+      mit # bun core
+      lgpl21Only # javascriptcore and webkit
     ];
     maintainers = with maintainers; [ DAlperin jk ];
     platforms = builtins.attrNames dists;

[DAlperin]

@06kellyjac applied the patch, thank you! @lucasew take a look. Think we can get this merged?
Appreciate the feedback from all on the best way to package this for the time being.

[lucasew]

inherit (dist) sha256;

[lucasew]

The latest version right now is 0.1.2

[Mindavi]

Whenever ofborg is happy good to go IMO. No need to update to 0.1.2 in this PR, you can do that in a follow up

[DAlperin]

@Mindavi ofborg seems happy. Can we go ahead and merge. I can update after in a quick follow up.

[github-actions]

Successfully created backport PR #180900 for release-22.05.