Skip to content

bitcoin: fix broken build on aarch64-darwin#179795

Merged
prusnak merged 1 commit intoNixOS:masterfrom
prusnak:bitcoin-fix
Jul 1, 2022
Merged

bitcoin: fix broken build on aarch64-darwin#179795
prusnak merged 1 commit intoNixOS:masterfrom
prusnak:bitcoin-fix

Conversation

@prusnak
Copy link
Member

@prusnak prusnak commented Jul 1, 2022 •
edited
Loading

Description of changes
Things done
  • Built on platform(s)
    • x86_64-linux
    • aarch64-linux
    • x86_64-darwin
    • aarch64-darwin
  • For non-Linux: Is sandbox = true set in nix.conf? (See Nix manual)
  • Tested, as applicable:
  • Tested compilation of all packages that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage
  • Tested basic functionality of all binary files (usually in ./result/bin/)
  • 22.11 Release Notes (or backporting 22.05 Release notes)
    • (Package updates) Added a release notes entry if the change is major or breaking
    • (Module updates) Added a release notes entry if the change is significant
    • (Module addition) Added a release notes entry if adding a new NixOS module
    • (Release notes changes) Ran nixos/doc/manual/md-to-db.sh to update generated release notes
  • Fits CONTRIBUTING.md.

@prusnak
bitcoin: fix broken build on aarch64-darwin
2838597 
by disabling stackprotector which kills the tests
@prusnak prusnak requested review from RaghavSood and mmahut as code owners July 1, 2022 12:27
@ofborg ofborg bot added the 6.topic: darwin Running or building packages on Darwin label Jul 1, 2022
@prusnak
Copy link
Member Author

prusnak commented Jul 1, 2022

@GrahamcOfBorg build bitcoind

@ofborg ofborg bot requested a review from roconnor July 1, 2022 12:36
@ofborg ofborg bot added 11.by: package-maintainer This PR was created by a maintainer of all the package it changes. 10.rebuild-darwin: 1-10 This PR causes between 1 and 10 packages to rebuild on Darwin. 10.rebuild-linux: 1-10 This PR causes between 1 and 10 packages to rebuild on Linux. labels Jul 1, 2022
@prusnak prusnak merged commit 6f1178e into NixOS:master Jul 1, 2022
@prusnak prusnak deleted the bitcoin-fix branch July 1, 2022 12:44
@github-actions github-actions bot mentioned this pull request Jul 1, 2022
Merged
1 task
@github-actions
Copy link
Contributor

github-actions bot commented Jul 1, 2022

Successfully created backport PR #179799 for release-22.05.

@prusnak prusnak mentioned this pull request Jul 1, 2022
Closed
@jiegec jiegec mentioned this pull request Jul 11, 2022
Closed
@thunderbiscuit thunderbiscuit mentioned this pull request Jul 21, 2022
Merged
@prusnak prusnak mentioned this pull request Jul 30, 2022
Merged
13 tasks
@prusnak
Copy link
Member Author

prusnak commented Jul 30, 2022

follow-up PR: #183951

prusnak added a commit that referenced this pull request Jul 30, 2022
@prusnak
bitcoin: fix broken build on aarch64-darwin
bd95ace 
fixes #179474
follow-up to #179795
github-actions bot pushed a commit that referenced this pull request Jul 30, 2022
@prusnak @github-actions
bitcoin: fix broken build on aarch64-darwin
46c2543 
fixes #179474
follow-up to #179795

(cherry picked from commit bd95ace)
dpc added a commit to dpc/fedimint that referenced this pull request Aug 9, 2022
@dpc
Switch to vanilla bitcoind
2edf2aa 
Plus:

```
nix flake lock --update-input nixpkgs
```
to use the newest one available in nixpkgs, to include:

* NixOS/nixpkgs#179795
* NixOS/nixpkgs#183951
@dpc dpc mentioned this pull request Aug 9, 2022
Merged
dpc added a commit to dpc/fedimint that referenced this pull request Aug 10, 2022
@dpc
Switch to vanilla bitcoind
3b2a5cf 
Plus:

```
nix flake lock --update-input nixpkgs
```
to use the newest one available in nixpkgs, to include:

* NixOS/nixpkgs#179795
* NixOS/nixpkgs#183951
dpc added a commit to dpc/fedimint that referenced this pull request Aug 10, 2022
@dpc
Switch to vanilla bitcoind
9433f52 
Plus:

```
nix flake lock --update-input nixpkgs
```
to use the newest one available in nixpkgs, to include:

* NixOS/nixpkgs#179795
* NixOS/nixpkgs#183951
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@mmahut mmahut Awaiting requested review from mmahut

@RaghavSood RaghavSood Awaiting requested review from RaghavSood

@roconnor roconnor Awaiting requested review from roconnor

Assignees

No one assigned

Labels

6.topic: darwin Running or building packages on Darwin 10.rebuild-darwin: 1-10 This PR causes between 1 and 10 packages to rebuild on Darwin. 10.rebuild-linux: 1-10 This PR causes between 1 and 10 packages to rebuild on Linux. 11.by: package-maintainer This PR was created by a maintainer of all the package it changes.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

1 participant

@prusnak