[staging] openldap: remove deprecated options, improve encapsulation #179597
Merged
mweinelt merged 9 commits intoNixOS:stagingfrom Jul 21, 2022
Merged
[staging] openldap: remove deprecated options, improve encapsulation #179597mweinelt merged 9 commits intoNixOS:stagingfrom
mweinelt merged 9 commits intoNixOS:stagingfrom
Conversation
By default, this is /run/ldapi, which is not compatible with systemd's runtime directories. Change it to /run/slapd/ldapi (in library and server). This makes `ldapi:///` work as a default socket again.
This fixes a bug I observed in deployment on a RPi, but not able to reproduce in tests.
Now that we use notify daemon type, this works safely and simplifies configuration.
This improves security, by starting the service as an unprivileged user, rather than starting as root and relying on the service to drop privileges. This requires a significant cleanup of pre-init scripts, to make use of StateDirectory and RuntimeDirectory for permissions.
This speeds up tests a bit. Also, ensure that mutable config works for manual config dir.
This addresses the original concern behind NixOS#92544
Use `openldap` for consistency between `/var/lib` and `/run`.
Mic92
requested review from
FRidh,
cdepillabout,
jonringer,
kalbasit,
maralorn,
sternenseemann,
stigtsp,
zakame and
zowoq
as code owners
github-actions
bot
added
6.topic: nixos
Mic92
removed request for
FRidh,
cdepillabout,
jonringer,
kalbasit,
maralorn,
sternenseemann,
stigtsp,
zakame and
zowoq
ofborg
bot
added
10.rebuild-darwin: 501+
Mic92
changed the title
kwohlfahrt
approved these changes
Jul 21, 2022
Contributor
kwohlfahrt
left a comment
kwohlfahrt
left a comment
There was a problem hiding this comment.
Ah, I didn't realize my original PR had gone stale. This all still looks good, sorry for the delay in reviewing, it's been a busy few weeks!
13 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description of changes
same as #176449 but conflicts resolved.
Things done
sandbox = trueset innix.conf? (See Nix manual)nix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage./result/bin/)nixos/doc/manual/md-to-db.shto update generated release notes