Conversation
By writing the unchecked outputs before checking them, they will be written to a store path, which appears in the log, and which sticks around even if the build fails. Eventually it is GCed, but until then, you can open the file. If you run it in a terminal+editor combination like VSCode, the failure location is just one Ctrl+click away.
I've tried XInclude set-xml-id first, but our tooling did not pick up on it.
This occurs in the ast generated for blockquotes.
Our tooling would trip without the inner <para>, despite the docbook docs suggesting that <para> occurs in <blockquote> and vice versa.
github-actions
bot
added
6.topic: nixos
ofborg
bot
added
10.rebuild-darwin: 0
pennae
left a comment
pennae
left a comment
There was a problem hiding this comment.
don't know enough about the xslt sheets to comment on those, but the rest looks good. 👍
There was a problem hiding this comment.
not sure having that hatch is such a great thing. we'll have to make some adjustment to the documentation to get it to work as markdown anyway, and if we have a hatch we have one more place to keep in mind when we finally axe docbook.
do you have a special use in mind where this is necessary? maybe a few more extension to the renderer would be better.
There was a problem hiding this comment.
I used it while I couldn't get blockquote accepted by the docbook tooling that runs after this. I suppose I could have used a plain old docbook description instead. I'll remove it.
Feature was introduced in NixOS#174460, but wasn't supported in `mergeJSON.py` yet.
roberth
force-pushed
the
option-docs-improvements
branch
from
a25cb0f to
7c81905
Compare
No worries, I'm somewhat familiar with them, and I've tested the change. |
2 participants
Description of changes
Some improvements I've found while working on the NixOS test framework (#176557). They're small fixes and quality of life improvements.
Things done
sandbox = trueset innix.conf? (See Nix manual)nix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage./result/bin/)nixos/doc/manual/md-to-db.shto update generated release notes