Skip to content

discord-development: init at {0.0.202,0.0.8759}#179212

Closed
IvarWithoutBones wants to merge 1 commit intoNixOS:masterfrom
IvarWithoutBones:init/discord-dev
Closed

discord-development: init at {0.0.202,0.0.8759}#179212
IvarWithoutBones wants to merge 1 commit intoNixOS:masterfrom
IvarWithoutBones:init/discord-dev

Conversation

@IvarWithoutBones
Copy link
Member

@IvarWithoutBones IvarWithoutBones commented Jun 26, 2022

Description of changes

This adds the development branch of discord, which wasn't packaged before. Note that I haven't tested the darwin version as I don't own a mac, I've just confirmed the hash is correct.

Things done
  • Built on platform(s)
    • x86_64-linux
    • aarch64-linux
    • x86_64-darwin
    • aarch64-darwin
  • For non-Linux: Is sandbox = true set in nix.conf? (See Nix manual)
  • Tested, as applicable:
  • Tested compilation of all packages that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage
  • Tested basic functionality of all binary files (usually in ./result/bin/)
  • 22.11 Release Notes (or backporting 22.05 Release notes)
    • (Package updates) Added a release notes entry if the change is major or breaking
    • (Module updates) Added a release notes entry if the change is significant
    • (Module addition) Added a release notes entry if adding a new NixOS module
    • (Release notes changes) Ran nixos/doc/manual/md-to-db.sh to update generated release notes
  • Fits CONTRIBUTING.md.

@ofborg ofborg bot added the 8.has: package (new) This PR adds a new package label Jun 26, 2022
@ofborg ofborg bot requested review from MP2E, devins2518 and ldesgoui June 26, 2022 17:09
@ofborg ofborg bot added 10.rebuild-darwin: 1-10 This PR causes between 1 and 10 packages to rebuild on Darwin. 10.rebuild-darwin: 1 This PR causes 1 package to rebuild on Darwin. 10.rebuild-linux: 1-10 This PR causes between 1 and 10 packages to rebuild on Linux. 10.rebuild-linux: 1 This PR causes 1 package to rebuild on Linux. labels Jun 26, 2022
winterqt
winterqt requested changes Jul 5, 2022
View reviewed changes
Copy link
Member

@winterqt winterqt left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Overall, this looks good, thanks!

moni-dz
moni-dz reviewed Jul 5, 2022
View reviewed changes
@IvarWithoutBones
Copy link
Member Author

IvarWithoutBones commented Jul 10, 2022 •
edited
Loading

Thanks for the reviews everyone, I've added all suggestions 👍

@winterqt would you mind testing the aarch64-darwin support?

@ofborg ofborg bot added the 11.by: package-maintainer This PR was created by a maintainer of all the package it changes. label Jul 10, 2022
@winterqt
Copy link
Member

winterqt commented Jul 10, 2022

@IvarWithoutBones Looks like you didn't change the instance of callPackage in all-packages, mind fixing that? Thanks!

@IvarWithoutBones
Copy link
Member Author

IvarWithoutBones commented Jul 10, 2022 •
edited
Loading

@IvarWithoutBones Looks like you didn't change the instance of callPackage in all-packages, mind fixing that? Thanks!

Unless I'm missing something, I think I did change it: https://github.com/NixOS/nixpkgs/pull/179212/files#diff-ab5748dc9567516fefba8344056b51ec1866adeace380f46e58a7af3d619ea22R35622

@winterqt
Copy link
Member

winterqt commented Jul 10, 2022

That's still pointing to a callPackage line.

@IvarWithoutBones
discord-development: init at {0.0.202,0.0.8759}
204ab89 
This also enables aarch64-darwin support for both Canary and the new
Development branch, based on NixOS#179379. Thanks :)
@IvarWithoutBones
Copy link
Member Author

IvarWithoutBones commented Jul 10, 2022

That's still pointing to a callPackage line.

Oops, guess i did miss something 😅 Should be good now.

@winterqt
Copy link
Member

winterqt commented Jul 11, 2022

Result of nixpkgs-review pr 179212 run on aarch64-darwin 1

2 packages built:
  • discord-canary
  • discord-development

@applePrincess applePrincess added the 2.status: merge conflict This PR has merge conflicts with the target branch label Nov 19, 2022
@jopejoe1 jopejoe1 mentioned this pull request Apr 17, 2023
Merged
12 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@winterqt winterqt winterqt approved these changes

@MP2E MP2E Awaiting requested review from MP2E

@ldesgoui ldesgoui Awaiting requested review from ldesgoui

@devins2518 devins2518 Awaiting requested review from devins2518

+1 more reviewer

@moni-dz moni-dz moni-dz left review comments

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

2.status: merge conflict This PR has merge conflicts with the target branch 8.has: package (new) This PR adds a new package 10.rebuild-darwin: 1-10 This PR causes between 1 and 10 packages to rebuild on Darwin. 10.rebuild-darwin: 1 This PR causes 1 package to rebuild on Darwin. 10.rebuild-linux: 1-10 This PR causes between 1 and 10 packages to rebuild on Linux. 10.rebuild-linux: 1 This PR causes 1 package to rebuild on Linux. 11.by: package-maintainer This PR was created by a maintainer of all the package it changes.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@IvarWithoutBones @winterqt @moni-dz @applePrincess