Skip to content

Comments

ghc: Work around broken pyopenssl on aarch64-darwin#179181

Merged
lovesegfault merged 2 commits intoNixOS:masterfrom
hercules-ci:fix-ghc-aarch64-darwin-pyopenssl
Jun 27, 2022
Merged

ghc: Work around broken pyopenssl on aarch64-darwin#179181
lovesegfault merged 2 commits intoNixOS:masterfrom
hercules-ci:fix-ghc-aarch64-darwin-pyopenssl

Conversation

@roberth
Copy link
Member

@roberth roberth commented Jun 26, 2022

Description of changes

Avoid #175875, build ghc on m1 again.

Things done
  • Evaluated on platform(s)
    • x86_64-linux
    • aarch64-linux
    • x86_64-darwin
    • aarch64-darwin
  • For non-Linux: Is sandbox = true set in nix.conf? (See Nix manual)
  • Tested, as applicable:
  • Tested compilation of all packages that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage
  • Tested basic functionality of all binary files (usually in ./result/bin/)
  • 22.11 Release Notes (or backporting 22.05 Release notes)
    • (Package updates) Added a release notes entry if the change is major or breaking
    • (Module updates) Added a release notes entry if the change is significant
    • (Module addition) Added a release notes entry if adding a new NixOS module
    • (Release notes changes) Ran nixos/doc/manual/md-to-db.sh to update generated release notes
  • Fits CONTRIBUTING.md.

@ofborg ofborg bot added the 6.topic: darwin Running or building packages on Darwin label Jun 26, 2022
@github-actions github-actions bot added the 6.topic: haskell General-purpose, statically typed, purely functional programming language label Jun 26, 2022
@ofborg ofborg bot added 10.rebuild-darwin: 0 This PR does not cause any packages to rebuild on Darwin. 10.rebuild-linux: 0 This PR does not cause any packages to rebuild on Linux. labels Jun 26, 2022
Copy link
Member

@sternenseemann sternenseemann left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

IMO this workaround should live in the pyopenssl or sphinx derivation itself, I don't see why this fix should be private to the GHC derivation (and only the 9.0.2 one at that).

@roberth roberth force-pushed the fix-ghc-aarch64-darwin-pyopenssl branch from c652e32 to e417fd1 Compare June 26, 2022 18:12
@roberth roberth force-pushed the fix-ghc-aarch64-darwin-pyopenssl branch from e417fd1 to 7898af7 Compare June 26, 2022 18:13
@roberth roberth requested a review from sternenseemann June 26, 2022 18:15
@ofborg ofborg bot added 8.has: package (new) This PR adds a new package 10.rebuild-darwin: 1-10 This PR causes between 1 and 10 packages to rebuild on Darwin. 10.rebuild-darwin: 1 This PR causes 1 package to rebuild on Darwin. 10.rebuild-linux: 1-10 This PR causes between 1 and 10 packages to rebuild on Linux. 10.rebuild-linux: 1 This PR causes 1 package to rebuild on Linux. and removed 10.rebuild-darwin: 0 This PR does not cause any packages to rebuild on Darwin. 10.rebuild-linux: 0 This PR does not cause any packages to rebuild on Linux. labels Jun 26, 2022
@lovesegfault lovesegfault merged commit 131b760 into NixOS:master Jun 27, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

6.topic: darwin Running or building packages on Darwin 6.topic: haskell General-purpose, statically typed, purely functional programming language 8.has: package (new) This PR adds a new package 10.rebuild-darwin: 1-10 This PR causes between 1 and 10 packages to rebuild on Darwin. 10.rebuild-darwin: 1 This PR causes 1 package to rebuild on Darwin. 10.rebuild-linux: 1-10 This PR causes between 1 and 10 packages to rebuild on Linux. 10.rebuild-linux: 1 This PR causes 1 package to rebuild on Linux.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants