Skip to content

python310Packages.urllib3: remove pyopenssl as it is no longer recommended #179159

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
SuperSandro2000 merged 1 commit into from
Jun 29, 2022
Merged

python310Packages.urllib3: remove pyopenssl as it is no longer recommended #179159

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 1 addition & 2 deletions pkgs/development/python-modules/selenium/default.nix
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -35,8 +35,7 @@ buildPythonPackage rec {
trio
trio-websocket
urllib3
] ++ urllib3.optional-dependencies.secure
++ urllib3.optional-dependencies.socks;
] ++ urllib3.optional-dependencies.socks;

checkInputs = [
pytestCheckHook
Expand Down
8 changes: 3 additions & 5 deletions pkgs/development/python-modules/urllib3/default.nix
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -2,14 +2,10 @@
, brotli
, brotlicffi
, buildPythonPackage
, certifi
, cryptography
, python-dateutil
, fetchPypi
, isPyPy
, idna
, mock
, pyopenssl
, pysocks
, pytest-freezegun
, pytest-timeout
Expand Down Expand Up @@ -65,7 +61,9 @@ buildPythonPackage rec {

passthru.optional-dependencies = {
brotli = if isPyPy then [ brotlicffi ] else [ brotli ];
secure = [ certifi cryptography idna pyopenssl ];
# we are removing secure dependencies as they are no longer relevant with py3:
# https://urllib3.readthedocs.io/en/stable/reference/contrib/pyopenssl.html
# secure = [ certifi cryptography idna pyopenssl ];
socks = [ pysocks ];
};

Expand Down