Skip to content

duckdb: add patch to fix list type inference#178886

Merged
SuperSandro2000 merged 4 commits intoNixOS:masterfrom
cpcloud:patch-duckdb
Jul 1, 2022
Merged

duckdb: add patch to fix list type inference#178886
SuperSandro2000 merged 4 commits intoNixOS:masterfrom
cpcloud:patch-duckdb

Conversation

@cpcloud
Copy link
Contributor

@cpcloud cpcloud commented Jun 24, 2022

Description of changes

This PR adds a patch to duckdb to pick up a change to fix list type inference.
Without this, duckdb-engine cannot be used to infer columns of type list.

Things done
  • Built on platform(s)
    • x86_64-linux
    • aarch64-linux
    • x86_64-darwin
    • aarch64-darwin
  • For non-Linux: Is sandbox = true set in nix.conf? (See Nix manual)
  • Tested, as applicable:
  • Tested compilation of all packages that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage
  • Tested basic functionality of all binary files (usually in ./result/bin/)
  • 22.11 Release Notes (or backporting 22.05 Release notes)
    • (Package updates) Added a release notes entry if the change is major or breaking
    • (Module updates) Added a release notes entry if the change is significant
    • (Module addition) Added a release notes entry if adding a new NixOS module
    • (Release notes changes) Ran nixos/doc/manual/md-to-db.sh to update generated release notes
  • Fits CONTRIBUTING.md.

@cpcloud cpcloud requested review from FRidh and jonringer as code owners June 24, 2022 18:19
@github-actions github-actions bot added the 6.topic: python Python is a high-level, general-purpose programming language. label Jun 24, 2022
@ofborg ofborg bot requested a review from costrouc June 24, 2022 18:28
@ofborg ofborg bot added 11.by: package-maintainer This PR was created by a maintainer of all the package it changes. 10.rebuild-darwin: 1-10 This PR causes between 1 and 10 packages to rebuild on Darwin. 10.rebuild-linux: 1-10 This PR causes between 1 and 10 packages to rebuild on Linux. labels Jun 24, 2022
@cpcloud
Copy link
Contributor Author

cpcloud commented Jul 1, 2022

@SuperSandro2000 Mind reviewing this one?

@SuperSandro2000 SuperSandro2000 merged commit a034fd5 into NixOS:master Jul 1, 2022
@cpcloud cpcloud deleted the patch-duckdb branch July 1, 2022 13:24
Kranzes pushed a commit to Kranzes/nixpkgs that referenced this pull request Jul 1, 2022
@cpcloud @Kranzes
duckdb: add patch to fix list type inference (NixOS#178886)
1d0e827
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@FRidh FRidh Awaiting requested review from FRidh

@jonringer jonringer Awaiting requested review from jonringer

@costrouc costrouc Awaiting requested review from costrouc

Assignees

No one assigned

Labels

6.topic: python Python is a high-level, general-purpose programming language. 10.rebuild-darwin: 1-10 This PR causes between 1 and 10 packages to rebuild on Darwin. 10.rebuild-linux: 1-10 This PR causes between 1 and 10 packages to rebuild on Linux. 11.by: package-maintainer This PR was created by a maintainer of all the package it changes.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@cpcloud @SuperSandro2000