Skip to content

openldap: disable parallel build#178864

Closed
YorikSar wants to merge 1 commit intoNixOS:masterfrom
tweag:openldap-disable-parallel-build
Closed

openldap: disable parallel build#178864
YorikSar wants to merge 1 commit intoNixOS:masterfrom
tweag:openldap-disable-parallel-build

Conversation

@YorikSar
Copy link
Contributor

Description of changes

The build failed on our 48-core machine, so it seems like it doesn't support it anymore.

libtool: link: cc -g -O2 -o .libs/ldif-filter ldif-filter.o slapd-common.o  ../../libraries/liblutil/liblutil.a ../../libraries/libldap/.libs/libldap.so /build/openldap-2.6.2/libraries/liblber/.libs/liblber.so ../../libraries/liblber/.libs/liblber.so /nix/store/zkw493raash35m4al6bhrzvvwm2f0bdi-cyrus-sasl-2.1.28/lib/libsasl2.so -lssl -lcrypto -lcrypt -Wl,-rpath -Wl,/nix/store/wj7pax447418mk0h0iv7kl8ybb8z1qsd-openldap-2.6.2/lib -Wl,-rpath -Wl,/nix/store/zkw493raash35m4al6bhrzvvwm2f0bdi-cyrus-sasl-2.1.28/lib
checking how to run the C preprocessor... gcc -E
/nix/store/cz52w8xf3i1d3xvzpzd9abf7rvpl9017-binutils-2.38/bin/ld: cannot find slapd-common.o: No such file or directory
...
collect2: error: ld returned 1 exit status
Things done
  • Built on platform(s)
    • x86_64-linux
    • aarch64-linux
    • x86_64-darwin
    • aarch64-darwin
  • For non-Linux: Is sandbox = true set in nix.conf? (See Nix manual)
  • Tested, as applicable:
  • Tested compilation of all packages that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage
  • Tested basic functionality of all binary files (usually in ./result/bin/)
  • 22.11 Release Notes (or backporting 22.05 Release notes)
    • (Package updates) Added a release notes entry if the change is major or breaking
    • (Module updates) Added a release notes entry if the change is significant
    • (Module addition) Added a release notes entry if adding a new NixOS module
    • (Release notes changes) Ran nixos/doc/manual/md-to-db.sh to update generated release notes
  • Fits CONTRIBUTING.md.

It failed on our 48 core machine with:

libtool: link: cc -g -O2 -o .libs/ldif-filter ldif-filter.o slapd-common.o  ../../libraries/liblutil/liblutil.a ../../libraries/libldap/.libs
/libldap.so /build/openldap-2.6.2/libraries/liblber/.libs/liblber.so ../../libraries/liblber/.libs/liblber.so /nix/store/zkw493raash35m4al6bh
rzvvwm2f0bdi-cyrus-sasl-2.1.28/lib/libsasl2.so -lssl -lcrypto -lcrypt -Wl,-rpath -Wl,/nix/store/wj7pax447418mk0h0iv7kl8ybb8z1qsd-openldap-2.6
.2/lib -Wl,-rpath -Wl,/nix/store/zkw493raash35m4al6bhrzvvwm2f0bdi-cyrus-sasl-2.1.28/lib
checking how to run the C preprocessor... gcc -E
/nix/store/cz52w8xf3i1d3xvzpzd9abf7rvpl9017-binutils-2.38/bin/ld: cannot find slapd-common.o: No such file or directory
...
collect2: error: ld returned 1 exit status
@ofborg ofborg bot requested review from ajs124, dasJ and mweinelt June 24, 2022 13:26
@ofborg ofborg bot added 10.rebuild-darwin: 501+ This PR causes many rebuilds on Darwin and should normally target the staging branches. 10.rebuild-darwin: 501-1000 This PR causes many rebuilds on Darwin and should normally target the staging branches. 10.rebuild-linux: 501+ This PR causes many rebuilds on Linux and should normally target the staging branches. 10.rebuild-linux: 2501-5000 This PR causes many rebuilds on Linux and should target the staging branches. labels Jun 24, 2022
Copy link
Member

@rapenne-s rapenne-s left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me.
It would be worth reporting this issue upstream so it might get fixed one day.

, fetchurl

# dependencies
# dependencies
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
# dependencies
# dependencies

@dasJ
Copy link
Member

dasJ commented Jun 24, 2022

This needs to go to staging where a fix for the parallel build should already be: #176290

@mweinelt
Copy link
Member

I've build this multiple times on 12/24/64 thread machines and the build was fine for me. Seems to be spurious then.

Also needs to go into staging.

@dasJ
Copy link
Member

dasJ commented Jun 24, 2022

Also for context, this is already a fixed issue: #175626

@YorikSar
Copy link
Contributor Author

@dasJ That's awesome, thanks! I guess, we should rebase our dev branch on master more often.

@YorikSar YorikSar closed this Jun 24, 2022
@YorikSar YorikSar deleted the openldap-disable-parallel-build branch June 24, 2022 13:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

10.rebuild-darwin: 501-1000 This PR causes many rebuilds on Darwin and should normally target the staging branches. 10.rebuild-darwin: 501+ This PR causes many rebuilds on Darwin and should normally target the staging branches. 10.rebuild-linux: 501+ This PR causes many rebuilds on Linux and should normally target the staging branches. 10.rebuild-linux: 2501-5000 This PR causes many rebuilds on Linux and should target the staging branches.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants