Skip to content

Add cmakeBuildType and dontAddCmakeBuildType variables to be able to make Debug builds. #17828

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
nbp wants to merge 1 commit into from
Closed

Add cmakeBuildType and dontAddCmakeBuildType variables to be able to make Debug builds. #17828

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
8 changes: 7 additions & 1 deletion pkgs/development/tools/build-managers/cmake/setup-hook.sh
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -49,7 +49,13 @@ cmakeConfigurePhase() {

# Avoid cmake resetting the rpath of binaries, on make install
# And build always Release, to ensure optimisation flags
Copy link
Member

@rasendubi rasendubi Aug 20, 2016

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The comment is now off

cmakeFlags="-DCMAKE_BUILD_TYPE=Release -DCMAKE_SKIP_BUILD_RPATH=ON $cmakeFlags"
cmakeFlags="-DCMAKE_SKIP_BUILD_RPATH=ON $cmakeFlags"

if [ -n "$cmakeBuildType" ]; then
cmakeFlags="-DCMAKE_BUILD_TYPE=$cmakeBuildType $cmakeFlags"
Copy link
Member

@ttuegel ttuegel Aug 18, 2016

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

If one appends -DCMAKE_BUILD_TYPE=Debug to cmakeFlags, does that not override the setting made here? In which case, we need only the dontAddBuildType option.

elif [ -z "dontAddBuildType" ]; then
Copy link
Member

@ttuegel ttuegel Aug 18, 2016

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This should read "$dontAddBuildType, it's missing the $.

A little bikeshedding here: could we call this cmakeDontSetBuildType instead? The cmake prefix matches the other CMake-specific variables. I'm less particular on Set instead of Add, but it sounds like a better verb to me.

cmakeFlags="-DCMAKE_BUILD_TYPE=Release $cmakeFlags"
fi

echo "cmake flags: $cmakeFlags ${cmakeFlagsArray[@]}"

Expand Down