Skip to content

Comments

nixos/tests/fcitx: disable#178041

Merged
SuperSandro2000 merged 1 commit intoNixOS:masterfrom
vcunat:p/annoying-tests
Jun 17, 2022
Merged

nixos/tests/fcitx: disable#178041
SuperSandro2000 merged 1 commit intoNixOS:masterfrom
vcunat:p/annoying-tests

Conversation

@vcunat
Copy link
Member

@vcunat vcunat commented Jun 17, 2022

It never worked on 21.11 and still does not:
https://hydra.nixos.org/job/nixos/release-21.11/nixos.tests.fcitx.x86_64-linux/all
https://hydra.nixos.org/job/nixos/trunk-combined/nixos.tests.fcitx.x86_64-linux/all
and it frequently makes big channels wait (same on aarch64-linux).

@vcunat vcunat added 6.topic: nixos Issues or PRs affecting NixOS modules, or package usability issues specific to NixOS backport release-21.11 labels Jun 17, 2022
@vcunat
Copy link
Member Author

vcunat commented Jun 17, 2022

🤔 I see @ericsagnes as meta.maintainer of the package (though not tests or nixos module).

@ofborg ofborg bot added 10.rebuild-darwin: 0 This PR does not cause any packages to rebuild on Darwin. 10.rebuild-linux: 0 This PR does not cause any packages to rebuild on Linux. labels Jun 17, 2022
@SuperSandro2000
Copy link
Member

If it is broken since months and no one noticed then it will be fine to disable it until someone fixed it.

@SuperSandro2000 SuperSandro2000 merged commit 558031d into NixOS:master Jun 17, 2022
@github-actions
Copy link
Contributor

Backport failed for release-21.11, because it was unable to cherry-pick the commit(s).

Please cherry-pick the changes locally.

git fetch origin release-21.11
git worktree add -d .worktree/backport-178041-to-release-21.11 origin/release-21.11
cd .worktree/backport-178041-to-release-21.11
git checkout -b backport-178041-to-release-21.11
ancref=$(git merge-base 103a4c0ae46afa9cf008c30744175315ca38e9f9 7e2a357edbea07debf27703d713c900fc6e8654c)
git cherry-pick -x $ancref..7e2a357edbea07debf27703d713c900fc6e8654c

@github-actions
Copy link
Contributor

Successfully created backport PR #178054 for release-22.05.

@vcunat vcunat deleted the p/annoying-tests branch June 22, 2022 17:39
@vcunat
Copy link
Member Author

vcunat commented Jun 22, 2022

Uh, weird, it's still being attempted: https://hydra.nixos.org/job/nixos/trunk-combined/nixos.tests.fcitx.x86_64-linux

@vcunat
Copy link
Member Author

vcunat commented Oct 3, 2022

Dropped now 🎉 Most likely thanks to PR #191540, based on a crude bisect with nix build -f. nixosTests.fcitx --dry-run

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

6.topic: nixos Issues or PRs affecting NixOS modules, or package usability issues specific to NixOS 10.rebuild-darwin: 0 This PR does not cause any packages to rebuild on Darwin. 10.rebuild-linux: 0 This PR does not cause any packages to rebuild on Linux.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants