python3: fix wrong platform libs when cross-compiling#177888
Merged
adisbladis merged 1 commit intoNixOS:masterfrom Jun 16, 2022
Merged
python3: fix wrong platform libs when cross-compiling#177888adisbladis merged 1 commit intoNixOS:masterfrom
adisbladis merged 1 commit intoNixOS:masterfrom
Conversation
see NixOS#169475 (comment) patch by adisbladis Co-authored-by: adisbladis <adisbladis@gmail.com>
Artturin
added
the
6.topic: cross-compilation
github-actions
bot
added
the
6.topic: python
13 tasks
Member
|
Maybe we should also update the comment? |
ofborg
bot
added
10.rebuild-darwin: 0
adisbladis
approved these changes
Jun 16, 2022
| @@ -82,7 +82,7 @@ let | |||
|
|
|||
| passthru = let | |||
| # When we override the interpreter we also need to override the spliced versions of the interpreter | |||
Member
There was a problem hiding this comment.
To clarify: i meant this comment. I am not sure if it is up to date anymore.
Member
There was a problem hiding this comment.
It is up to date and correct. The difference here is that passthruFun can carry derivations in the function closure too that are not filtered out.
1 task
Contributor
|
Successfully created backport PR #177945 for |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
see #169475 (comment)
patch by adisbladis
Co-authored-by: adisbladis adisbladis@gmail.com
Description of changes
Things done
sandbox = trueset innix.conf? (See Nix manual)nix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage./result/bin/)nixos/doc/manual/md-to-db.shto update generated release notes