logrotate: do not add mail if 'mail = false' is specified#177106
Merged
aanderse merged 1 commit intoNixOS:masterfrom Jun 26, 2022
Merged
logrotate: do not add mail if 'mail = false' is specified#177106aanderse merged 1 commit intoNixOS:masterfrom
aanderse merged 1 commit intoNixOS:masterfrom
Conversation
5 tasks
Reported-by: Ricardo M. Correia <rcorreia@wizy.org>
Member
Author
|
I hadn't noticed tests failed: n.mail is not necessarily a bool (it'll often be a string in practice, the destination mail address) so adjusted the fold to work with strings. |
13 tasks
Member
|
Merging because @wizeman approved. Thanks! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Reported-by: Ricardo M. Correia rcorreia@wizy.org @wizeman
Description of changes
module would incorrectly pull in sendmail if mail was explicitly disabled
Things done
sandbox = trueset innix.conf? (See Nix manual)nix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage./result/bin/)nixos/doc/manual/md-to-db.shto update generated release notes