Skip to content

nixos/version: Require a stateVersion#176295

Open
dasJ wants to merge 1 commit intoNixOS:masterfrom
helsinki-systems:feat/require-stateversion
Open

nixos/version: Require a stateVersion#176295
dasJ wants to merge 1 commit intoNixOS:masterfrom
helsinki-systems:feat/require-stateversion

Conversation

@dasJ
Copy link
Member

@dasJ dasJ commented Jun 4, 2022

22.05 shows a warning for this, so we can safely remove it now. Users
were warned.

Closes #65314

Description of changes
Things done
  • Built on platform(s)
    • x86_64-linux
    • aarch64-linux
    • x86_64-darwin
    • aarch64-darwin
  • For non-Linux: Is sandbox = true set in nix.conf? (See Nix manual)
  • Tested, as applicable:
  • Tested compilation of all packages that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage
  • Tested basic functionality of all binary files (usually in ./result/bin/)
  • 22.11 Release Notes (or backporting 22.05 Release notes)
    • (Package updates) Added a release notes entry if the change is major or breaking
    • (Module updates) Added a release notes entry if the change is significant
    • (Module addition) Added a release notes entry if adding a new NixOS module
    • (Release notes changes) Ran nixos/doc/manual/md-to-db.sh to update generated release notes
  • Fits CONTRIBUTING.md.

@dasJ dasJ requested review from ajs124 and pennae June 4, 2022 21:38
@github-actions github-actions bot added 6.topic: nixos Issues or PRs affecting NixOS modules, or package usability issues specific to NixOS 8.has: module (update) This PR changes an existing module in `nixos/` labels Jun 4, 2022
@dasJ dasJ requested a review from peterhoeg June 4, 2022 21:38
@dasJ dasJ force-pushed the feat/require-stateversion branch from b634500 to a463e23 Compare June 4, 2022 21:41
@pennae
Copy link
Contributor

pennae commented Jun 4, 2022

there are a bunch more instances of eval-config being run all over the nixos tree, eg in the gnome installer and a bunch of hydra jobs. those will all need adjusting as well. not sure that's all though, there may be hidden instances lurking.

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Was going to suggest throwing a custom error in default, but that will obfuscate which system is missing this info. The module system's built-in message includes the entire attribute path.
(This is assuming NixOS gets hooked into a deployment tool's module system correctly; can't vouch for each of them, but NixOps has an open PR that will accomplish this.)

@roberth
Copy link
Member

roberth commented Jun 5, 2022

22.05 shows a warning for this, so we can safely remove it now.

It's only been merged for less than a month though #124261 (comment)
Not sure how often nixos-unstable users generally update, but it seems a bit short.

22.05 shows a warning for this, so we can safely remove it now. Users
were warned.
@dasJ dasJ force-pushed the feat/require-stateversion branch from a463e23 to 691842f Compare August 31, 2022 17:38
@ofborg ofborg bot added 8.has: clean-up This PR removes packages or removes other cruft 10.rebuild-darwin: 0 This PR does not cause any packages to rebuild on Darwin. 10.rebuild-linux: 1-10 This PR causes between 1 and 10 packages to rebuild on Linux. 10.rebuild-linux: 1 This PR causes 1 package to rebuild on Linux. labels Aug 31, 2022
@wegank wegank added 2.status: stale https://github.com/NixOS/nixpkgs/blob/master/.github/STALE-BOT.md 2.status: merge conflict This PR has merge conflicts with the target branch labels Mar 19, 2024
@stale stale bot removed the 2.status: stale https://github.com/NixOS/nixpkgs/blob/master/.github/STALE-BOT.md label Mar 20, 2024
@wegank wegank added the 2.status: stale https://github.com/NixOS/nixpkgs/blob/master/.github/STALE-BOT.md label Jul 4, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

2.status: merge conflict This PR has merge conflicts with the target branch 2.status: stale https://github.com/NixOS/nixpkgs/blob/master/.github/STALE-BOT.md 6.topic: nixos Issues or PRs affecting NixOS modules, or package usability issues specific to NixOS 8.has: clean-up This PR removes packages or removes other cruft 8.has: module (update) This PR changes an existing module in `nixos/` 10.rebuild-darwin: 0 This PR does not cause any packages to rebuild on Darwin. 10.rebuild-linux: 1-10 This PR causes between 1 and 10 packages to rebuild on Linux. 10.rebuild-linux: 1 This PR causes 1 package to rebuild on Linux.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants