Skip to content

ledger: fix Python 3.10 module build#175665

Merged
dotlambda merged 1 commit intoNixOS:masterfrom
reckenrode:ledger-darwin-fix
Jun 1, 2022
Merged

ledger: fix Python 3.10 module build#175665
dotlambda merged 1 commit intoNixOS:masterfrom
reckenrode:ledger-darwin-fix

Conversation

@reckenrode
Copy link
Contributor

@reckenrode reckenrode commented May 31, 2022

Description of changes

The current default boost (1.77) doesn’t work with Python 3.10, so use 1.79 instead. This fixes the Hydra failure that resulted in ledger being marked broken on Darwin.

Sandbox is set to relaxed on Darwin.

Things done
  • Built on platform(s)
    • x86_64-linux
    • aarch64-linux
    • x86_64-darwin
    • aarch64-darwin
  • For non-Linux: Is sandbox = true set in nix.conf? (See Nix manual)
  • Tested, as applicable:
  • Tested compilation of all packages that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage
  • Tested basic functionality of all binary files (usually in ./result/bin/)
  • 22.11 Release Notes (or backporting 22.05 Release notes)
    • (Package updates) Added a release notes entry if the change is major or breaking
    • (Module updates) Added a release notes entry if the change is significant
    • (Module addition) Added a release notes entry if adding a new NixOS module
    • (Release notes changes) Ran nixos/doc/manual/md-to-db.sh to update generated release notes
  • Fits CONTRIBUTING.md.

@github-actions github-actions bot added the 6.topic: python Python is a high-level, general-purpose programming language. label May 31, 2022
@reckenrode
Copy link
Contributor Author

reckenrode commented May 31, 2022

Result of nixpkgs-review pr 175665 run on aarch64-darwin 1

2 packages built:
  • python310Packages.ledger
  • python39Packages.ledger

@reckenrode
Copy link
Contributor Author

reckenrode commented May 31, 2022

Result of nixpkgs-review pr 175665 run on x86_64-darwin 1

2 packages built:
  • python310Packages.ledger
  • python39Packages.ledger

@ofborg ofborg bot added the 6.topic: darwin Running or building packages on Darwin label May 31, 2022
@ofborg ofborg bot requested review from jwiegley and marsam June 1, 2022 00:01
@ofborg ofborg bot added 10.rebuild-darwin: 1-10 This PR causes between 1 and 10 packages to rebuild on Darwin. 10.rebuild-linux: 1-10 This PR causes between 1 and 10 packages to rebuild on Linux. labels Jun 1, 2022
dotlambda
dotlambda reviewed Jun 1, 2022
View reviewed changes
@reckenrode
Copy link
Contributor Author

reckenrode commented Jun 1, 2022

Result of nixpkgs-review pr 175665 run on x86_64-linux 1

2 packages built:
  • python310Packages.ledger
  • python39Packages.ledger

@reckenrode reckenrode force-pushed the ledger-darwin-fix branch from 07a903b to 6dfb803 Compare June 1, 2022 03:24
@dotlambda
Copy link
Member

dotlambda commented Jun 1, 2022

Result of nixpkgs-review pr 175665 run on x86_64-linux 1

2 packages built:
  • python310Packages.ledger
  • python39Packages.ledger

@dotlambda
Copy link
Member

dotlambda commented Jun 1, 2022

@ofborg build python310.pkgs.ledger

dotlambda
dotlambda reviewed Jun 1, 2022
View reviewed changes
@reckenrode
ledger: fix Python 3.10 module build
d4964be 
The current default boost (1.77) doesn’t work with Python 3.10, so use
1.79 instead.
@reckenrode reckenrode force-pushed the ledger-darwin-fix branch from 6dfb803 to d4964be Compare June 1, 2022 04:35
@dotlambda dotlambda changed the title ledger: fix Python 3.10 module build on Darwin ledger: fix Python 3.10 module build Jun 1, 2022
@dotlambda
Copy link
Member

dotlambda commented Jun 1, 2022

@ofborg build python310.pkgs.ledger

dotlambda
dotlambda reviewed Jun 1, 2022
View reviewed changes
pkgs/top-level/python-packages.nix

ledger = (toPythonModule (pkgs.ledger.override {
usePython = true;
boost = pkgs.boost179; # Current default boost (1.77) doesn’t work with Python 3.10.
Copy link
Member

@dotlambda dotlambda Jun 1, 2022

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This should be removed once #175694 is merged.

Copy link
Member

@dotlambda dotlambda Jun 10, 2022

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

done in edfc49f

@dotlambda dotlambda merged commit 8b9c2fb into NixOS:master Jun 1, 2022
@github-actions github-actions bot mentioned this pull request Jun 1, 2022
Merged
1 task
@github-actions
Copy link
Contributor

github-actions bot commented Jun 1, 2022

Successfully created backport PR #175697 for release-22.05.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@dotlambda dotlambda dotlambda left review comments

@FRidh FRidh Awaiting requested review from FRidh

@jonringer jonringer Awaiting requested review from jonringer

@marsam marsam Awaiting requested review from marsam

@jwiegley jwiegley Awaiting requested review from jwiegley

Assignees

No one assigned

Labels

6.topic: darwin Running or building packages on Darwin 6.topic: python Python is a high-level, general-purpose programming language. 10.rebuild-darwin: 1-10 This PR causes between 1 and 10 packages to rebuild on Darwin. 10.rebuild-linux: 1-10 This PR causes between 1 and 10 packages to rebuild on Linux.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@reckenrode @dotlambda