Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

python310Packages.miniaudio: fix build on Darwin #175205

Merged
merged 1 commit into from
May 29, 2022
Merged

python310Packages.miniaudio: fix build on Darwin #175205

merged 1 commit into from
May 29, 2022

Conversation

dotlambda
Copy link
Member

Description of changes
Things done
  • Built on platform(s)
    • x86_64-linux
    • aarch64-linux
    • x86_64-darwin
    • aarch64-darwin
  • For non-Linux: Is sandbox = true set in nix.conf? (See Nix manual)
  • Tested, as applicable:
  • Tested compilation of all packages that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage
  • Tested basic functionality of all binary files (usually in ./result/bin/)
  • 22.05 Release Notes (or backporting 21.11 Release notes)
    • (Package updates) Added a release notes entry if the change is major or breaking
    • (Module updates) Added a release notes entry if the change is significant
    • (Module addition) Added a release notes entry if adding a new NixOS module
    • (Release notes changes) Ran nixos/doc/manual/md-to-db.sh to update generated release notes
  • Fits CONTRIBUTING.md.

ZHF: #172160

@dotlambda dotlambda added the 6.topic: darwin Running or building packages on Darwin label May 28, 2022
@reckenrode
Copy link
Contributor

reckenrode commented May 28, 2022 •
edited
Loading

This builds for me on aarch64-darwin once I also add AudioToolbox to builtInputs.

@dotlambda dotlambda requested a review from reckenrode May 28, 2022 23:48
@reckenrode
Copy link
Contributor

Result of nixpkgs-review pr 175205 run on aarch64-darwin 1

4 packages built:
  • python310Packages.miniaudio
  • python310Packages.pyatv
  • python39Packages.miniaudio
  • python39Packages.pyatv

reckenrode
reckenrode approved these changes May 29, 2022
View reviewed changes
Copy link
Contributor

@reckenrode reckenrode left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@reckenrode
Copy link
Contributor

Result of nixpkgs-review pr 175205 run on x86_64-darwin 1

4 packages built:
  • python310Packages.miniaudio
  • python310Packages.pyatv
  • python39Packages.miniaudio
  • python39Packages.pyatv

@dotlambda dotlambda marked this pull request as ready for review May 29, 2022 00:15
@dotlambda dotlambda merged commit 57436c5 into NixOS:master May 29, 2022
@dotlambda dotlambda deleted the miniaudio-darwin branch May 29, 2022 00:15
@github-actions github-actions bot mentioned this pull request May 29, 2022
Merged
1 task
@github-actions
Copy link
Contributor

Successfully created backport PR #175216 for release-22.05.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@reckenrode reckenrode reckenrode approved these changes

@FRidh FRidh Awaiting requested review from FRidh

@jonringer jonringer Awaiting requested review from jonringer

Assignees
No one assigned
Labels
6.topic: darwin Running or building packages on Darwin 6.topic: python 10.rebuild-darwin: 1-10 10.rebuild-linux: 0 11.by: package-maintainer
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@dotlambda @reckenrode