rust: 1.60.0 -> 1.61.0

[lblasc]

Description of changes

nix-build -p fd passes on x86_64-linux

Waiting for Firefox and Thunderbird.

Things done

• Built on platform(s)
  • x86_64-linux
  • aarch64-linux
  • x86_64-darwin
  • aarch64-darwin
• For non-Linux: Is sandbox = true set in nix.conf? (See Nix manual)
• Tested, as applicable:
  • NixOS test(s) (look inside nixos/tests)
  • and/or package tests
  • or, for functions and "core" functionality, tests in lib/tests or pkgs/test
  • made sure NixOS tests are linked to the relevant packages
• Tested compilation of all packages that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage
• Tested basic functionality of all binary files (usually in ./result/bin/)
• 22.05 Release Notes (or backporting 21.11 Release notes)
  • (Package updates) Added a release notes entry if the change is major or breaking
  • (Module updates) Added a release notes entry if the change is significant
  • (Module addition) Added a release notes entry if adding a new NixOS module
  • (Release notes changes) Ran nixos/doc/manual/md-to-db.sh to update generated release notes
• Fits CONTRIBUTING.md.

[Mic92]

I started an darwin-aarch64 build (might take a while because it's building stdenv...)

[mweinelt]

Building & testing both firefox and thunderbird. Edit: Both are looking fine.

[Mic92]

I started an aarch64-linux build as well.

[lblasc]

firefox and thunderbird are fine on x86_64-linux

[zowoq]

Built fd on x86_64-darwin.

[Smaug123]

(noise, but I can't hide this comment)

These are the ones which are already broken on master for darwin-aarch64.

ario (broken on master):

error: builder for '/nix/store/m6690w3bbshd5n3m7l6ci11w9g851l7g-ario-1.6.drv' failed with exit code 2;
       last 10 log lines:
       >       _ario_filesystem_init in ario-filesystem.o
       > ld: symbol(s) not found for architecture arm64
       > clang-11: error: linker command failed with exit code 1 (use -v to see invocation)
       > make[3]: *** [Makefile:492: libfilesystem.la] Error 1
       > make[3]: Leaving directory '/private/tmp/nix-build-ario-1.6.drv-0/ario-1.6/plugins/filesystem'

cargo-watch (broken on master):

error: builder for '/nix/store/jff549glvi4rh4543y5z935r8v1q367x-cargo-watch-8.1.2.drv' failed with exit code 101;
       last 10 log lines:
       >   cargo:warning=8 errors generated.
       >   exit status: 1
       >
       >   --- stderr
       >
       >
       >   error occurred: Command "/nix/store/630b4hj9z3gj62c4fw3q7sxy1akql5l4-clang-wrapper-11.1.0/bin/cc" "-O3" "-ffunction-sections" "-fdata-sections" "-fPIC" "-arch" "arm64" "-fmodules" "-o" "/private/tmp/nix-build-cargo-watch-8.1.2.drv-0/source/target/aarch64
-apple-darwin/release/build/mac-notification-sys-ecb4ee1922ea5572/out/objc/notify.o" "-c" "objc/notify.m" with args "cc" did not execute successfully (status code exit status: 1).

coq8.15-InfSeqExt, and indeed large tracts of coq which just seems extremely borked:

error: builder for '/nix/store/hb3kpbnh4hhfhy4171g6bg91jp49abfr-coq8.15-InfSeqExt-20200131.drv' failed with exit code 2;
       last 10 log lines:
       > patching sources
       > updateAutotoolsGnuConfigScriptsPhase
       > configuring
       > patching script interpreter paths in ./configure
       > ./configure: interpreter directive changed from "#!/usr/bin/env bash" to "/nix/store/lkw407y1x1v5bg6hc290c5ry1qaabbgl-bash-5.1-p16/bin/bash"
       > configure flags: --prefix=/nix/store/jsd7bf802fapdzbk2srgpv2r4ahr3p2k-coq8.15-InfSeqExt-20200131
       > building
       > build flags: -j10 -l10 SHELL=/nix/store/lkw407y1x1v5bg6hc290c5ry1qaabbgl-bash-5.1-p16/bin/bash
       > coq_makefile -f _CoqProject -o Makefile.coq
       > make: *** [Makefile:17: Makefile.coq] Killed: 9

Lighthouse (not packaged for darwin-aarch64 on master):

error: builder for '/nix/store/jp798jjyayzjb0sdcmasa9yarqpr3g1s-Lighthouse-unstable-2021-03-28.drv' failed with exit code 101;
       last 10 log lines:
       > warning: unused import: `Peripheral`
       >  --> src/main.rs:1:38
       >   |
       > 1 | use btleplug::api::{BDAddr, Central, Peripheral, WriteType};
       >   |                                      ^^^^^^^^^^
       >
       > Some errors have detailed explanations: E0412, E0433.
       > For more information about an error, try `rustc --explain E0412`.
       > warning: `lighthouse` (bin "lighthouse") generated 2 warnings

MozWire (broken on master):

error: builder for '/nix/store/qc1s4r54br04xjjiz2wp37n02kg7n6ih-MozWire-0.7.0.drv' failed with exit code 101;
       last 10 log lines:
       >   ^
       >   /private/tmp/nix-build-MozWire-0.7.0.drv-0/MozWire-0.7.0-vendor.tar.gz/ring/pregenerated/aesv8-armx-linux64.S:403:1: error: unknown directive
       >   .size GFp_aes_hw_ctr32_encrypt_blocks,.-GFp_aes_hw_ctr32_encrypt_blocks
       >   ^
       >   /private/tmp/nix-build-MozWire-0.7.0.drv-0/MozWire-0.7.0-vendor.tar.gz/ring/pregenerated/aesv8-armx-linux64.S:407:19: error: unexpected token in '.section' directive
       >   .section .note.GNU-stack,"",%progbits
       >                     ^
       >   thread 'main' panicked at 'execution failed', /private/tmp/nix-build-MozWire-0.7.0.drv-0/MozWire-0.7.0-vendor.tar.gz/ring/build.rs:664:9
       >   note: run with `RUST_BACKTRACE=1` environment variable to display a backtrace

cobalt (broken on master):

error: builder for '/nix/store/9hfd8v743228cpq09ssd2hb2m6r3vw5g-cobalt-0.17.5.drv' failed with exit code 101;
       last 10 log lines:
       >   cargo:rerun-if-env-changed=PKG_CONFIG_SYSROOT_DIR_aarch64_apple_darwin
       >   cargo:rerun-if-env-changed=HOST_PKG_CONFIG_SYSROOT_DIR
       >   cargo:rerun-if-env-changed=PKG_CONFIG_SYSROOT_DIR
       >   cargo:rustc-link-search=native=/private/tmp/nix-build-cobalt-0.17.5.drv-0/source/target/aarch64-apple-darwin/release/build/sass-sys-8ce8ec035831d48e/out/build/lib
       >   cargo:rustc-link-lib=static=sass
       >
       >   --- stderr
       >   thread 'main' panicked at 'no c++ library found', /private/tmp/nix-build-cobalt-0.17.5.drv-0/cobalt-0.17.5-vendor.tar.gz/sass-sys/build.rs:80:9

eccodes (broken on master):

error: builder for '/nix/store/1iwvgxbcm8p4zy9vlhdk83c1xxkfjlxg-eccodes-2.24.2.drv' failed with exit code 1;
       last 10 log lines:
       >
       >   CMake will not be able to correctly generate this project.
       > Call Stack (most recent call first):
       >   cmake/ecbuild_enable_fortran.cmake:46 (enable_language)
       >   CMakeLists.txt:144 (ecbuild_enable_fortran)
       >
       >
       > -- Configuring incomplete, errors occurred!

alfis (broken on master):

error: builder for '/nix/store/3zxl3bvij93zm7lz4f4najlm9ck1wbp0-alfis-0.7.3.drv' failed with exit code 101;
       last 10 log lines:
       >   cargo:warning=20 errors generated.
       >   exit status: 1
       >
       >   --- stderr
       >
       >
       >   error occurred: Command "/nix/store/630b4hj9z3gj62c4fw3q7sxy1akql5l4-clang-wrapper-11.1.0/bin/cc" "-O3" "-ffunction-sections" "-fdata-sections" "-fPIC" "-arch" "arm64" "-I" "webview.h" "-Wall" "-Wextra" "-x" "objective-c" "-std=c11" "-w" "-DDEBUG" "-DOBJ
C_OLD_DISPATCH_PROTOTYPES=1" "-o" "/private/tmp/nix-build-alfis-0.7.3.drv-0/source/target/aarch64-apple-darwin/release/build/webview-sys-74e297695eb3c632/out/webview_cocoa.o" "-c" "webview_cocoa.c" with args "cc" did not execute successfully (status code exit statu
s: 1).

gbl (broken on master):

error: builder for '/nix/store/03wjypdfs7bhipfzxfa9sjh6qzk087hs-gbl-0.3.1.drv' failed with exit code 101;
       last 10 log lines:
       >   ^
       >   /private/tmp/nix-build-gbl-0.3.1.drv-0/gbl-0.3.1-vendor.tar.gz/ring/pregenerated/aesv8-armx-linux64.S:223:1: error: unknown directive
       >   .type GFp_aes_hw_ctr32_encrypt_blocks,%function
       >   ^
       >   /private/tmp/nix-build-gbl-0.3.1.drv-0/gbl-0.3.1-vendor.tar.gz/ring/pregenerated/aesv8-armx-linux64.S:402:1: error: unknown directive
       >   .size GFp_aes_hw_ctr32_encrypt_blocks,.-GFp_aes_hw_ctr32_encrypt_blocks
       >   ^
       >   thread 'main' panicked at 'execution failed', /private/tmp/nix-build-gbl-0.3.1.drv-0/gbl-0.3.1-vendor.tar.gz/ring/build.rs:638:9
       >   note: run with `RUST_BACKTRACE=1` environment variable to display a backtrace

gssdp (broken on master):

error: builder for '/nix/store/4yr9z967ss06rapmsadbgfsql0v9v2h4-gssdp-1.4.0.1.drv' failed with exit code 1;
       last 10 log lines:
       > Expected Fail:      0
       > Fail:               1
       > Unexpected Pass:    0
       > Skipped:            0
       > Timeout:            0
       >
       > Full log written to /private/tmp/nix-build-gssdp-1.4.0.1.drv-0/gssdp-1.4.0.1/build/meson-logs/testlog.txt
       > FAILED: meson-test
       > /nix/store/k0kx1w6k5q9nsaabjkx1jzky2an6fvmm-meson-0.61.2/bin/meson test --no-rebuild --print-errorlogs
       > ninja: build stopped: subcommand failed.

gurk-rs (broken on master):

error: builder for '/nix/store/6yl80wmv6paa5ykw2rf36b3i6mjpvcgb-gurk-rs-0.2.3.drv' failed with exit code 101;
       last 10 log lines:
       >   cargo:warning=1 error generated.
       >   exit status: 1
       >
       >   --- stderr
       >
       >
       >   error occurred: Command "/nix/store/630b4hj9z3gj62c4fw3q7sxy1akql5l4-clang-wrapper-11.1.0/bin/cc" "-O3" "-ffunction-sections" "-fdata-sections" "-fPIC" "-arch" "arm64" "-fmodules" "-o" "/private/tmp/nix-build-gurk-rs-0.2.3.drv-0/source/target/aarch64-app
le-darwin/release/build/mac-notification-sys-734da0cc56354164/out/objc/notify.o" "-c" "objc/notify.m" with args "cc" did not execute successfully (status code exit status: 1).

jsonwatch (broken on master):

error: builder for '/nix/store/rj16ijakbqnjkfwgncnq1cxz5750m5d7-jsonwatch-0.6.0.drv' failed with exit code 101;
       last 10 log lines:
       >   ^
       >   /private/tmp/nix-build-jsonwatch-0.6.0.drv-0/jsonwatch-0.6.0-vendor.tar.gz/ring/pregenerated/aesv8-armx-linux64.S:223:1: error: unknown directive
       >   .type GFp_aes_hw_ctr32_encrypt_blocks,%function
       >   ^
       >   /private/tmp/nix-build-jsonwatch-0.6.0.drv-0/jsonwatch-0.6.0-vendor.tar.gz/ring/pregenerated/aesv8-armx-linux64.S:402:1: error: unknown directive
       >   .size GFp_aes_hw_ctr32_encrypt_blocks,.-GFp_aes_hw_ctr32_encrypt_blocks
       >   ^
       >   thread 'main' panicked at 'execution failed', /private/tmp/nix-build-jsonwatch-0.6.0.drv-0/jsonwatch-0.6.0-vendor.tar.gz/ring/build.rs:643:9
       >   note: run with `RUST_BACKTRACE=1` environment variable to display a backtrace

a52dec (broken on master):

error: builder for '/nix/store/2sv4c9r6fa06ni7s6sbgrvw8fkdk4295-a52dec-0.7.4.drv' failed with exit code 2;
       last 10 log lines:
       >     a52dec.o
       >     ../libao/libao.a(audio_out_peak.o)
       > duplicate symbol '___sputc' in:
       >     a52dec.o
       >     ../libao/libao.a(audio_out_peak.o)
       > ld: 28 duplicate symbols for architecture arm64
       > clang-11: error: linker command failed with exit code 1 (use -v to see invocation)
       > make[1]: *** [Makefile:210: a52dec] Error 1
       > make[1]: Leaving directory '/private/tmp/nix-build-a52dec-0.7.4.drv-0/a52dec-0.7.4/src'
       > make: *** [Makefile:152: all-recursive] Error 1

mate.mate-menus:

error: builder for '/nix/store/rkqw1ymvcfy6wsd7530ibk6riys9783x-mate-menus-1.26.0.drv' failed with exit code 2;
       last 10 log lines:
       > In file included from desktop-entries.c:23:
       > ./desktop-entries.h:24:10: fatal error: 'gio/gdesktopappinfo.h' file not found
       > #include <gio/gdesktopappinfo.h>
       >          ^~~~~~~~~~~~~~~~~~~~~~~
       > 1 error generated.
       > make[2]: *** [Makefile:556: desktop-entries.lo] Error 1
       > make[2]: Leaving directory '/private/tmp/nix-build-mate-menus-1.26.0.drv-0/mate-menus-1.26.0/libmenu'
       > make[1]: *** [Makefile:465: all-recursive] Error 1
       > make[1]: Leaving directory '/private/tmp/nix-build-mate-menus-1.26.0.drv-0/mate-menus-1.26.0'
       > make: *** [Makefile:397: all] Error 2

pqrs:

error: builder for '/nix/store/44f8mg6jw0s7n65h3gwmhzvgyw6849xb-pqrs-0.1.1.drv' failed with exit code 101;
       last 10 log lines:
       >      |
       >      = help: the trait `Div<u32>` is not implemented for `usize`
       >
       >    Compiling clap v2.33.3
       >    Compiling rand_core v0.6.1
       >    Compiling brotli v3.3.0
       > Some errors have detailed explanations: E0277, E0308.
       > For more information about an error, try `rustc --explain E0277`.
       > error: could not compile `lexical-core` due to 27 previous errors

(this is in e.g. pqrs-0.1.1-vendor.tar.gz/lexical-core/src/atof/algorithm/bhcomp.rs:62:24, a great deal of "error[E0277]: cannot divide usize by u32")

[Smaug123]

(likely noise, but I can't hide this comment)

Ones which work on darwin-aarch64 master, fail on nixpgs-review, but appear to be nothing to do with this PR.

bsnes-hd-10.6-beta (works on master):

Error: builder for '/nix/store/rizpmhl6zqk2nql21ak8hq8iqln418v1-bsnes-hd-10.6-beta.drv' failed with exit code 2;
       last 10 log lines:
       >     ^~~~~~~~~~~~
       >     Application
       > ../hiro/core/application.hpp:2:8: note: 'Application' declared here
       > struct Application {
       >        ^
       > fatal error: too many errors emitted, stopping now [-ferror-limit=]
       > 20 errors generated.
       > make: *** [../hiro/GNUmakefile:73: obj/hiro-gtk3.o] Error 1

Lua (works on master):

error: builder for '/nix/store/x4lc9133ypkc2y311gnkkkwmixi5qf4s-lua-2.1.0.drv' failed with exit code 1;
       last 10 log lines:
       > No pkg-config found
       > Using runghc version 9.0.2 found on system at:
       > /nix/store/hba3lasnwfq1ibhdvf3kjxcm8fb1b75s-ghc-9.0.2/bin/runghc
       > Using strip found on system at:
       > /nix/store/630b4hj9z3gj62c4fw3q7sxy1akql5l4-clang-wrapper-11.1.0/bin/strip
       > Using tar found on system at:
       > /nix/store/xvl9fyl923ac1h2m19hb9qcvg06ia00l-gnutar-1.34/bin/tar
       > No uhc found
       > building
       > Preprocessing library for lua-2.1.0..

Luarocks (works on master):

error: builder for '/nix/store/hxj1i98a2rb5z9qpd3y02bgy7dmdadr7-luarocks-3.8.0.drv' failed with exit code 2;
       last 10 log lines:
       > mkdir -p .luarocks
       > cp ./build/config-.lua .luarocks/config-.lua
       > rm -f src/luarocks/core/hardcoded.lua
       > echo "#!/bin/sh" > luarocks
       > echo "unset LUA_PATH LUA_PATH_5_2 LUA_PATH_5_3 LUA_PATH_5_4 LUA_CPATH LUA_CPATH_5_2 LUA_CPATH_5_3 LUA_CPATH_5_4" >> luarocks
       > echo 'LUAROCKS_SYSCONFDIR="/nix/store/m2kif3dkmm350f5x8cf98zk02r6krpq5-luarocks-3.8.0/etc/luarocks" LUA_PATH="/private/tmp/nix-build-luarocks-3.8.0.drv-0/source/src/?.lua;;" exec "/nix/store/wd8hrv7ddw7ls82hmy1bssj5ilgyi90p-lua-5.1.5/bin/lua" "/private/tmp
/nix-build-luarocks-3.8.0.drv-0/source/src/bin/luarocks" --project-tree="/private/tmp/nix-build-luarocks-3.8.0.drv-0/source/lua_modules" "$@"' >> luarocks
       > chmod +rx ./luarocks
       > ./luarocks init
       > make: *** [GNUmakefile:57: luarocks] Killed: 9
       > make: *** Deleting file 'luarocks'

mikutter (works on master):

error: builder for '/nix/store/1q00cvw2gjfmda100yf45iv0d7px32fa-mikutter-4.1.4.drv' failed with exit code 137;
       last 10 log lines:
       > post-installation fixup
       > rewriting symlink /nix/store/342bkdwz33wz2m2y1s9c0zqvzzab69hv-mikutter-4.1.4/Applications/mikutter.app/Contents/MacOS/mikutter to be relative to /nix/store/342bkdwz33wz2m2y1s9c0zqvzzab69hv-mikutter-4.1.4
       > strip is /nix/store/bi8ya5scc3305x4wa4nay5gmvriq4pxv-cctools-port-949.0.1/bin/strip
       > stripping (with command strip and flags -S) in /nix/store/342bkdwz33wz2m2y1s9c0zqvzzab69hv-mikutter-4.1.4/bin
       > patching script interpreter paths in /nix/store/342bkdwz33wz2m2y1s9c0zqvzzab69hv-mikutter-4.1.4
       > /nix/store/342bkdwz33wz2m2y1s9c0zqvzzab69hv-mikutter-4.1.4/opt/mikutter/core/miku/miku.rb: interpreter directive changed from "#! /usr/bin/ruby" to "/nix/store/qnqacjkzxmzkwhbvn45a3cz05yywjiqk-wrapped-ruby-mikutter-gems/bin/ruby"
       > /nix/store/342bkdwz33wz2m2y1s9c0zqvzzab69hv-mikutter-4.1.4/opt/mikutter/.mikutter.rb-wrapped: interpreter directive changed from "#!/bin/sh" to "/nix/store/lkw407y1x1v5bg6hc290c5ry1qaabbgl-bash-5.1-p16/bin/sh"
       > /nix/store/342bkdwz33wz2m2y1s9c0zqvzzab69hv-mikutter-4.1.4/opt/mikutter/test.rb: interpreter directive changed from "#! /usr/bin/ruby" to "/nix/store/qnqacjkzxmzkwhbvn45a3cz05yywjiqk-wrapped-ruby-mikutter-gems/bin/ruby"
       > running install tests
       > /nix/store/3zqj93rzxlff2945pn58wwdd6g5v655q-stdenv-darwin/setup: line 1386: 53481 Killed: 9               $out/bin/mikutter --confroot="$testDir" --plugin=test_plugin --debug

freeciv (works on master):

error: builder for '/nix/store/gjab97jzhmgapr96az83nkr0951rnsz7-freeciv-2.6.6.drv' failed with exit code 2;
       last 10 log lines:
       > clang-11: error: linker command failed with exit code 137 (use -v to see invocation)
       > make[4]: *** [Makefile:641: tolua] Error 137
       > make[4]: Leaving directory '/private/tmp/nix-build-freeciv-2.6.6.drv-0/source/dependencies/tolua-5.2/src/bin'
       > make[3]: *** [Makefile:610: all-recursive] Error 1

geoclue2 (works on master):

error: builder for '/nix/store/kqcmv39idy6cxwpf2i7scmi23gzwmwfn-geoclue-2.5.7.drv' failed with exit code 1;
       last 10 log lines:
       > [71/76] Generating demo/geoclue-where-am-i.desktop with a custom command
       > [72/76] Compiling C object demo/agent.p/meson-generated_.._.._interface_geoclue-agent-interface.c.o
       > [73/76] Compiling C object demo/agent.p/gclue-service-agent.c.o
       > FAILED: demo/agent.p/gclue-service-agent.c.o
       > clang -Idemo/agent.p -Idemo -I../demo -I. -I.. -Ipublic-api -I../public-api -Iinterface -I/nix/store/c5ch1qzhd6vhiy1cdzjyj9siwchn90k1-glib-2.72.1-dev/include/glib-2.0 -I/nix/store/vclpi6g4pcwxnsiigiyqch2pgwsvyyg9-glib-2.72.1/lib/glib-2.0/include -I/nix/sto
re/c5ch1qzhd6vhiy1cdzjyj9siwchn90k1-glib-2.72.1-dev/include -I/nix/store/c5ch1qzhd6vhiy1cdzjyj9siwchn90k1-glib-2.72.1-dev/include/gio-unix-2.0 -I/nix/store/b59z7z3sa17zg3p492wb37790qykqin0-libnotify-0.7.12-dev/include -I/nix/store/gsyr8dyxyg7fkwpzc63j676w8j5f0s1s-g
dk-pixbuf-2.42.8-dev/include/gdk-pixbuf-2.0 -fcolor-diagnostics -Wall -Winvalid-pch -O0 -MD -MQ demo/agent.p/gclue-service-agent.c.o -MF demo/agent.p/gclue-service-agent.c.o.d -o demo/agent.p/gclue-service-agent.c.o -c ../demo/gclue-service-agent.c
       > ../demo/gclue-service-agent.c:26:10: fatal error: 'gio/gdesktopappinfo.h' file not found
       > #include <gio/gdesktopappinfo.h>
       >          ^~~~~~~~~~~~~~~~~~~~~~~
       > 1 error generated.
       > ninja: build stopped: subcommand failed.

[yu-re-ka]

@Smaug123 many of these packages don't even depend on Rust. Sorry but this is just not useful at all.
I would rather not block this for a long time because of aarch64-darwin failures. If anyone can deliver actually useful failure reports on aarch64-darwin we could keep 1.60 packaged and as default for aarch64-darwin.
Otherwise I would merge this as-is.

[Smaug123]

Fair enough; there are a few Rust ones in there, but they can presumably be cleared up after the fact.

[yu-re-ka]

Useful would be "x does build on master but does not build with this change". If you can re-test all of these on master and filter out those that also fail there we could actually derive some meaning from it.
There is also nix-review, which determines by evaluation which packages are affected by this change and only builds those.

[Smaug123]

Certainly, I was intending to do this all over again on master afterwards, but this PR takes many days to build; my M1 Max has been maxed out for two days now, so "afterwards" is not yet.

(For what it's worth, the number of times I've been rescued by random snippets of nix build traces on apparently unrelated GitHub issues makes me strongly prefer to default to putting them somewhere, and there's not really any official place to do it.)

[yu-re-ka]

The official place for build failures that are not related to any PR would be creating a seperate issue for that (title could be "lua does not build on aarch64-darwin").
Maybe do each package on master first, and then if it builds on master test it on this branch? That could save you a lot of build time, because you don't even have to attempt to build those that already failed on master with this PR. And prevents noise in the PR.

[Smaug123]

There is also nix-review, which determines by evaluation which packages are affected by this change and only builds those.

This is nix-review in action, by the way. To the best of my knowledge, these are all downstream of this change.

[yu-re-ka]

Ah, then this might be because this branch is based on staging, but nix-review compared to master?

[Smaug123]

nixpkgs-review's docs say that it "will merge the pull request into the pull request's target branch (most commonly master)", and it's definitely working against staging because the most recent commit in ~/.cache/nixpkgs-review/pr-173631 is aac2235 . But 🤷

[yu-re-ka]

A friend reports that fd builds fine from this PR on aarch64-darwin

[Smaug123]

This is the ones which work on master darwin-aarch64 but were broken according to nixpkgs-review, and which appear to be Rust-related. Apparently I can't hide the above comments containing the ones which are broken on master, or which nix-review thinks are newly broken but don't appear to be Rust-related.

Ignore if desired.

elfcat (works on master):

error: builder for '/nix/store/47mrd63jml82bcj4axbr6wg81h8bhgyz-elfcat-0.1.7-vendor.tar.gz.drv' failed with exit code 1;
       last 10 log lines:
       > configuring
       > no configure script, doing nothing
       > building
       > There is no dependency to vendor in this project.
       > Traceback (most recent call last):
       >   File "/nix/store/vnifbm7k6jxf3r0r2a7gpwp7ihsp9dw7-cargo-vendor-normalise/bin/.cargo-vendor-normalise-wrapped", line 42, in <module>
       >     main()
       >   File "/nix/store/vnifbm7k6jxf3r0r2a7gpwp7ihsp9dw7-cargo-vendor-normalise/bin/.cargo-vendor-normalise-wrapped", line 17, in main
       >     assert list(data.keys()) == ["source"]
       > AssertionError

---

cargo-generate (works on master):

error: builder for '/nix/store/xd6gikpdzfwvrgfmncy5bysigwznaxpv-cargo-generate-0.12.0.drv' failed with exit code 101;
       last 10 log lines:
       >     = note: consider importing this function:
       >             std::env::args
       >
       >    Compiling liquid-core v0.23.2
       >    Compiling liquid-lib v0.23.1
       >    Compiling git2 v0.13.25
       >    Compiling liquid v0.23.1
       > For more information about this error, try `rustc --explain E0425`.
       > error: could not compile `rhai` due to 47 previous errors
       > warning: build failed, waiting for other jobs to finish...

More specifically:

error[E0425]: cannot find value `args` in this scope
   --> /private/tmp/nix-build-cargo-generate-0.12.0.drv-0/cargo-generate-0.12.0-vendor.tar.gz/rhai/src/packages/arithmetic.rs:238:45
    |
238 | gen_signed_functions!(signed_numbers => i8, i16, i32);
    |                                             ^^^ not found in this scope
    |
    = note: consider importing this function:
            std::env::args

error[E0425]: cannot find value `args` in this scope
  --> /private/tmp/nix-build-cargo-generate-0.12.0.drv-0/cargo-generate-0.12.0-vendor.tar.gz/rhai/src/packages/logic.rs:85:29
   |
85 | gen_cmp_functions!(float => f32);
   |                             ^^^ not found in this scope
   |
   = note: consider importing this function:
           std::env::args

error[E0425]: cannot find value `args` in this scope
   --> /private/tmp/nix-build-cargo-generate-0.12.0.drv-0/cargo-generate-0.12.0-vendor.tar.gz/rhai/src/packages/math_basic.rs:528:66
    |
528 | gen_conversion_as_functions!(num_128_to_float => to_float (i128, u128) -> FLOAT);
    |                                                                  ^^^^ not found in this scope
    |
    = note: consider importing this function:
            std::env::args

error[E0425]: cannot find value `args` in this scope
   --> /private/tmp/nix-build-cargo-generate-0.12.0.drv-0/cargo-generate-0.12.0-vendor.tar.gz/rhai/src/packages/math_basic.rs:530:54
    |
530 | gen_conversion_as_functions!(basic_to_int => to_int (char) -> INT);
    |                                                      ^^^^ not found in this scope
    |
    = note: consider importing this function:
            std::env::args

error[E0425]: cannot find value `args` in this scope
   --> /private/tmp/nix-build-cargo-generate-0.12.0.drv-0/cargo-generate-0.12.0-vendor.tar.gz/rhai/src/packages/math_basic.rs:539:56
    |
539 | gen_conversion_as_functions!(num_128_to_int => to_int (i128, u128) -> INT);
    |                                                        ^^^^ not found in this scope
    |
    = note: consider importing this function:
            std::env::args

error[E0425]: cannot find value `args` in this scope
   --> /private/tmp/nix-build-cargo-generate-0.12.0.drv-0/cargo-generate-0.12.0-vendor.tar.gz/rhai/src/packages/math_basic.rs:539:62
    |
539 | gen_conversion_as_functions!(num_128_to_int => to_int (i128, u128) -> INT);
    |                                                              ^^^^ not found in this scope
    |
    = note: consider importing this function:
            std::env::args

---

dotter:

error: builder for '/nix/store/2hys10lkn5vphyp3395zj7pi7c6r02s9-dotter-0.12.10.drv' failed with exit code 101;
       last 10 log lines:
       >    --> /private/tmp/nix-build-dotter-0.12.10.drv-0/dotter-0.12.10-vendor.tar.gz/rhai/src/packages/math_basic.rs:539:62
       >     |
       > 539 | gen_conversion_as_functions!(num_128_to_int => to_int (i128, u128) -> INT);
       >     |                                                              ^^^^ not found in this scope
       >     |
       >     = note: consider importing this function:
       >             std::env::args
       >
       > For more information about this error, try `rustc --explain E0425`.
       > error: could not compile `rhai` due to 47 previous errors

These errors all appear to be the same rhai ones as in cargo-generate.

---

dotenv-linter (works on master, but surely an error of this shape is not caused by a rustc upgrade):

error: builder for '/nix/store/5gc6nk01mzkdckp03mcg8c5x81gfyalj-dotenv-linter-3.2.0.drv' failed with exit code 101;
       last 10 log lines:
       >    Compiling update-informer v0.2.0
       >    Compiling dotenv-linter v3.2.0 (/private/tmp/nix-build-dotenv-linter-3.2.0.drv-0/source)
       > error: linking with `/nix/store/630b4hj9z3gj62c4fw3q7sxy1akql5l4-clang-wrapper-11.1.0/bin/cc` failed: exit status: 1
       >   |
       >   = note: "/nix/store/630b4hj9z3gj62c4fw3q7sxy1akql5l4-clang-wrapper-11.1.0/bin/cc" "-arch" "arm64" "/private/tmp/nix-build-dotenv-linter-3.2.0.drv-0/source/target/aarch64-apple-darwin/release/deps/dotenv_linter-11c79816badd5ec2.dotenv_linter.21a199c0-cgu.
0.rcgu.o" "-L" "/private/tmp/nix-build-dotenv-linter-3.2.0.drv-0/source/target/aarch64-apple-darwin/release/deps" "-L" "/private/tmp/nix-build-dotenv-linter-3.2.0.drv-0/source/target/release/deps" "-L" "/private/tmp/nix-build-dotenv-linter-3.2.0.drv-0/source/target
/aarch64-apple-darwin/release/build/ring-09384eed980ec2c8/out" "-L" "/nix/store/3s9l3yn4zzhz1i9vs0j6zmbvlipal3yh-rustc-1.61.0/lib/rustlib/aarch64-apple-darwin/lib" "/private/tmp/nix-build-dotenv-linter-3.2.0.drv-0/rustckSCCmY/libring-432b2b54ba9542e2.rlib" "/nix/st
ore/3s9l3yn4zzhz1i9vs0j6zmbvlipal3yh-rustc-1.61.0/lib/rustlib/aarch64-apple-darwin/lib/libcompiler_builtins-2c3a0cc128bcaaa8.rlib" "-framework" "Security" "-liconv" "-lSystem" "-lresolv" "-lc" "-lm" "-liconv" "-L" "/nix/store/3s9l3yn4zzhz1i9vs0j6zmbvlipal3yh-rustc-
1.61.0/lib/rustlib/aarch64-apple-darwin/lib" "-o" "/private/tmp/nix-build-dotenv-linter-3.2.0.drv-0/source/target/aarch64-apple-darwin/release/deps/dotenv_linter-11c79816badd5ec2" "-Wl,-dead_strip" "-nodefaultlibs"
       >   = note: ld: framework not found Security
       >           clang-11: error: linker command failed with exit code 1 (use -v to see invocation)
       >
       >
       > error: could not compile `dotenv-linter` due to previous error

[Mic92]

aarch64-linux and aarch64-darwin can build fd.

[Mic92]

Regarding cargo-generate, we should first try if simply upgraded to https://github.com/cargo-generate/cargo-generate/releases/tag/v0.13.1 fixes the build again.

[Mic92]

elfcat looks like the vendoring in buildRustPackage is broken. The code run there is before any rustc binary is involved.

[vcunat]

cargo-generate: /cc maintainer @turboMaCk

Parent PR: #175150