[Backport release-21.11] nixos/wrappers: require argc to be at least one#173287
Closed
github-actions[bot] wants to merge 2 commits intorelease-21.11from
Closed
[Backport release-21.11] nixos/wrappers: require argc to be at least one#173287github-actions[bot] wants to merge 2 commits intorelease-21.11from
github-actions[bot] wants to merge 2 commits intorelease-21.11from
Conversation
C's assert macro only works when NDEBUG is undefined. Previously NDEBUG was undefined incorrectly which meant that the assert macros in wrapper.c did not work. (cherry picked from commit 1009d6e)
setuid applications were exploited in the past with an empty argv, such as pkexec using CVE-2021-4034. (cherry picked from commit 2a6a3d2)
13 tasks
ofborg
bot
added
10.rebuild-darwin: 0
lheckemann
added
the
1.severity: security
Member
|
Unfortunately NixOS 21.11 has reached its end-of-life status on 2022-07-01, one month after the release of NixOS 22.05. Since we do not accept any changes to its branches anymore, I'm closing this pull request. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Bot-based backport to
release-21.11, triggered by a label in #156822.