Skip to content

stdenv: start deprecating non-list configureFlags#173172

Merged
SuperSandro2000 merged 2 commits intoNixOS:masterfrom
Artturin:deprecatestringconf
May 19, 2022
Merged

stdenv: start deprecating non-list configureFlags#173172
SuperSandro2000 merged 2 commits intoNixOS:masterfrom
Artturin:deprecatestringconf

Conversation

@Artturin
Copy link
Member

@Artturin Artturin commented May 15, 2022 •
edited
Loading

the motivation for this is to simplify stdenv and ease the job of
reviewers due to them needing to tell contributors about the defacto
rule that configureFlags should be a list of strings

Supersedes #45886

Description of changes
Things done
  • Built on platform(s)
    • x86_64-linux
    • aarch64-linux
    • x86_64-darwin
    • aarch64-darwin
  • For non-Linux: Is sandbox = true set in nix.conf? (See Nix manual)
  • Tested, as applicable:
  • Tested compilation of all packages that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage
  • Tested basic functionality of all binary files (usually in ./result/bin/)
  • 22.05 Release Notes (or backporting 21.11 Release notes)
    • (Package updates) Added a release notes entry if the change is major or breaking
    • (Module updates) Added a release notes entry if the change is significant
    • (Module addition) Added a release notes entry if adding a new NixOS module
    • (Release notes changes) Ran nixos/doc/manual/md-to-db.sh to update generated release notes
  • Fits CONTRIBUTING.md.

@Artturin Artturin requested a review from SuperSandro2000 May 15, 2022 17:30
@github-actions github-actions bot added 6.topic: ocaml OCaml is a general-purpose, high-level, multi-paradigm programming language. 6.topic: stdenv Standard environment labels May 15, 2022
Ericson2314
Ericson2314 approved these changes May 15, 2022
View reviewed changes
Copy link
Member

@Ericson2314 Ericson2314 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Woo!!

@ofborg ofborg bot added 10.rebuild-darwin: 0 This PR does not cause any packages to rebuild on Darwin. 10.rebuild-linux: 0 This PR does not cause any packages to rebuild on Linux. labels May 15, 2022
@Artturin Artturin added the 12.approvals: 2 This PR was reviewed and approved by two persons. label May 16, 2022
@Artturin Artturin force-pushed the deprecatestringconf branch from 3335c30 to 9c19d14 Compare May 16, 2022 18:46
@Artturin
Copy link
Member Author

Artturin commented May 16, 2022

added a release note

@github-actions github-actions bot added 6.topic: nixos Issues or PRs affecting NixOS modules, or package usability issues specific to NixOS 8.has: changelog This PR adds or changes release notes 8.has: documentation This PR adds or changes documentation labels May 16, 2022
@ofborg ofborg bot added 10.rebuild-linux: 1-10 This PR causes between 1 and 10 packages to rebuild on Linux. and removed 10.rebuild-linux: 0 This PR does not cause any packages to rebuild on Linux. labels May 16, 2022
roberth
roberth reviewed May 16, 2022
View reviewed changes
@Artturin Artturin force-pushed the deprecatestringconf branch from 9c19d14 to f228824 Compare May 17, 2022 01:41
@github-actions github-actions bot removed 8.has: documentation This PR adds or changes documentation 8.has: changelog This PR adds or changes release notes 6.topic: nixos Issues or PRs affecting NixOS modules, or package usability issues specific to NixOS labels May 17, 2022
@Artturin Artturin force-pushed the deprecatestringconf branch from f228824 to ee86eaa Compare May 17, 2022 01:47
@ofborg ofborg bot added 10.rebuild-linux: 0 This PR does not cause any packages to rebuild on Linux. and removed 10.rebuild-linux: 1-10 This PR causes between 1 and 10 packages to rebuild on Linux. labels May 17, 2022
SuperSandro2000
SuperSandro2000 approved these changes May 17, 2022
View reviewed changes
Copy link
Member

@SuperSandro2000 SuperSandro2000 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🎉

@Artturin Artturin requested a review from roberth May 18, 2022 16:47
roberth
roberth reviewed May 18, 2022
View reviewed changes
Artturin added 2 commits May 18, 2022 20:32
@Artturin
stdenv: start deprecating non-list configureFlags
6d54fe6 
the motivation for this is to simplify stdenv and ease the job of
reviewers due to them needing to tell contributors about the defacto
rule that configureFlags should be a list of strings
@Artturin
treewide: convert string configureFlags to list of strings
cf74768
@Artturin Artturin force-pushed the deprecatestringconf branch from ee86eaa to cf74768 Compare May 18, 2022 17:32
@Artturin Artturin removed the 12.approvals: 2 This PR was reviewed and approved by two persons. label May 18, 2022
@Artturin Artturin requested a review from roberth May 18, 2022 23:21
@SuperSandro2000 SuperSandro2000 merged commit ed58443 into NixOS:master May 19, 2022
@Artturin Artturin deleted the deprecatestringconf branch May 19, 2022 12:54
@Artturin Artturin mentioned this pull request Jul 4, 2022
Merged
13 tasks
@Artturin
Copy link
Member Author

Artturin commented Jul 4, 2022

#180067

@Artturin Artturin mentioned this pull request Oct 4, 2022
Merged
13 tasks
Artturin added a commit to Artturin/nixpkgs that referenced this pull request Oct 10, 2022
@Artturin
treewide: *Flags convert to list from str
f4ea120 
*Flags implies a list

slightly relevant:
> stdenv: start deprecating non-list configureFlags NixOS#173172

the makeInstalledTests function in `nixos/tests/installed-tests/default.nix` isn't available outside of nixpkgs so
it's not a breaking change
@oneingan oneingan mentioned this pull request Jan 1, 2023
Closed
13 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@roberth roberth roberth approved these changes

@Ericson2314 Ericson2314 Ericson2314 approved these changes

@SuperSandro2000 SuperSandro2000 SuperSandro2000 approved these changes

@Mindavi Mindavi Mindavi approved these changes

@matthewbauer matthewbauer Awaiting requested review from matthewbauer

Assignees

No one assigned

Labels

6.topic: ocaml OCaml is a general-purpose, high-level, multi-paradigm programming language. 6.topic: stdenv Standard environment 10.rebuild-darwin: 0 This PR does not cause any packages to rebuild on Darwin. 10.rebuild-linux: 0 This PR does not cause any packages to rebuild on Linux.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

5 participants

@Artturin @roberth @Ericson2314 @SuperSandro2000 @Mindavi