Skip to content

mold: wrap with ld-wrapper #172452

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
tobim wants to merge 3 commits into from
Closed

mold: wrap with ld-wrapper #172452

Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
e00094a
mold: wrap with ld-wrapper
tobim May 10, 2022
29ab3b7
Update pkgs/development/tools/mold/default.nix
tobim Aug 16, 2022
6708c94
Explain variable definitions
tobim Aug 16, 2022
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
34 changes: 34 additions & 0 deletions pkgs/development/tools/mold/default.nix
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,6 +1,7 @@
{ stdenv
, fetchFromGitHub
, lib
, coreutils
, autoPatchelfHook
, cmake
, llvmPackages_latest
Expand Down Expand Up @@ -30,6 +31,39 @@ stdenv.mkDerivation rec {
LTO = 1;
makeFlags = [ "PREFIX=${placeholder "out"}" ];

# The next three variables are substituted into the script scaffold below.
# add-flags.sh; add-hardening.sh; ld-wrapper.sh; utils.bash
suffixSalt = lib.replaceStrings ["-" "."] ["_" "_"] stdenv.targetPlatform.config;
# utils.bash
wrapperName = "MOLD_WRAPPER";
# ld-wrapper.sh; utils.bash
coreutils_bin = lib.getBin coreutils;

postInstall = let
targetPrefix = lib.optionalString (stdenv.targetPlatform != stdenv.hostPlatform) (stdenv.targetPlatform.config + "-");
in ''
mkdir -p $out/nix-support

mv $out/bin/mold $out/bin/.mold

export prog=$out/bin/.mold
Comment on lines +47 to +49
Copy link
Member

@SuperSandro2000 SuperSandro2000 Aug 15, 2022

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Why not use wrapProgram or makeWrapper?

Copy link
Contributor Author

@tobim tobim Aug 16, 2022

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

i don't understand how those tools would help solve the problem in a better way.

Copy link
Member

@Mic92 Mic92 Sep 14, 2022

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I don't think this would help here.

substituteAll \
${../../../build-support/bintools-wrapper/ld-wrapper.sh} \
"$out/bin/${targetPrefix}mold"
chmod +x "$out/bin/${targetPrefix}mold"
ln -s $out/bin/${targetPrefix}mold $out/bin/${targetPrefix}ld

substituteAll \
${../../../build-support/bintools-wrapper/add-flags.sh} \
$out/nix-support/add-flags.sh
substituteAll \
${../../../build-support/bintools-wrapper/add-hardening.sh} \
$out/nix-support/add-hardening.sh
substituteAll \
${../../../build-support/wrapper-common/utils.bash} \
$out/nix-support/utils.bash
'';

passthru = {
updateScript = nix-update-script {
attrPath = pname;
Expand Down