Closed
Conversation
Contributor
Author
|
I didn't see a maintainers list for the lua interpreters package so if there is someone else I should be cc-ing on this let me know. I'm not sure if it's worth having this be conditionally used on darwin as opposed to all platforms but that would also be an option. |
Contributor
Author
|
I have tested on a darwin M1 macbook and it seems to work. I have not tested on linux or x86 platforms. |
Contributor
Author
|
This cannot be considered complete yet but it appears to work for |
Contributor
|
Hello!
|
Darwin execve has issues with shebang lines that point to other scripts with shebang lines. A new makeBinaryWrapper hook was added to workaround the issue on darwin. See NixOS#171473 and NixOS#23018 for more information. This uses that binary wrapper to fix packages like sile. I'm not sure this can be considered complete but it appears to work for sile at least.
Contributor
Author
|
I closed and reopened a different one to target staging at: #172749 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Darwin execve has issues with shebang lines that point to other scripts
with shebang lines. A new makeBinaryWrapper hook was added to workaround
the issue on darwin. See #171473 and #23018 for more information. This
uses that binary wrapper to fix packages like sile.
cc: @doronbehar, alerque
Things done
sandbox = trueset innix.conf? (See Nix manual)nix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage./result/bin/)nixos/doc/manual/md-to-db.shto update generated release notes