Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

matrix-appservice-irc: init at 0.3.1 #17213

Closed
wants to merge 1 commit into from

Conversation

Ralith
Copy link
Contributor

@Ralith Ralith commented Jul 23, 2016

Motivation for this change

Provides IRC bridging for the Matrix chat network.

Things done
  • Tested using sandboxing
    (nix.useChroot on NixOS,
    or option build-use-chroot in nix.conf
    on non-NixOS)
  • Built on platform(s)
    • NixOS
    • OS X
    • Linux
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nox --run "nox-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Fits CONTRIBUTING.md.

@mention-bot
Copy link

@Ralith, thanks for your PR! By analyzing the annotation information on this pull request, we identified @edolstra, @bjornfor and @offlinehacker to be potential reviewers

@joachifm
Copy link
Contributor

Is it really necessary to check in more than 10000 lines for a single package?

@Ralith
Copy link
Contributor Author

Ralith commented Aug 27, 2016

I have very poor understanding of the npm packaging infrastructure, but this is certainly not the only package that includes a npm2nix generated file. I've experimented some but haven't been able to work out a way to get it to work with the default top-level one. If there's a better way, I'd love to hear about it.

@joachifm
Copy link
Contributor

If nodejs stuff requires 10,000+ lines per package we seriously need to reconsider how things are done on that front.

@Ralith
Copy link
Contributor Author

Ralith commented Aug 27, 2016

It looks like the NPM/nodejs infrastructure is being reworked in #16886 although recent activity is limited. Should this be blocked by it?

@joachifm
Copy link
Contributor

Should this be blocked by it?

As far as I'm concerned, yes. I'm not checking in 10,000+ lines of code for a single package. Somebody else might do it, however, my opinion is by no means authoritative.

@fpletz
Copy link
Member

fpletz commented Aug 15, 2017

No progress for over a year. We will not merge this in the current form but feel free to reopen if things have improved.

@fpletz fpletz closed this Aug 15, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants