Skip to content

intel-graphics-compiler: follow-ups#171731

Merged
lovesegfault merged 5 commits intoNixOS:masterfrom
lovesegfault:igm-fixup
May 6, 2022
Merged

intel-graphics-compiler: follow-ups#171731
lovesegfault merged 5 commits intoNixOS:masterfrom
lovesegfault:igm-fixup

Conversation

@lovesegfault
Copy link
Member

Description of changes

Addresses some review comments that came in after I merged #171656

  • spirv-llvm-translator: move spirv-tools to nativeBuildInputs
  • intel-graphics-compiler: reindent
  • spirv-llvm-translator: remove prePatch since we don't run tests
  • intel-graphics-compiler: remove INSTALL_SPIRVDLL
  • intel-graphics-compiler: move substitutes to postPatch

cc. @calbrecht @wentasah

Things done
  • Built on platform(s)
    • x86_64-linux
    • aarch64-linux
    • x86_64-darwin
    • aarch64-darwin
  • For non-Linux: Is sandbox = true set in nix.conf? (See Nix manual)
  • Tested, as applicable:
  • Tested compilation of all packages that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage
  • Tested basic functionality of all binary files (usually in ./result/bin/)
  • 22.05 Release Notes (or backporting 21.11 Release notes)
    • (Package updates) Added a release notes entry if the change is major or breaking
    • (Module updates) Added a release notes entry if the change is significant
    • (Module addition) Added a release notes entry if adding a new NixOS module
    • (Release notes changes) Ran nixos/doc/manual/md-to-db.sh to update generated release notes
  • Fits CONTRIBUTING.md.

@ofborg ofborg bot requested a review from gloaming May 5, 2022 23:02
@ofborg ofborg bot added 10.rebuild-darwin: 1-10 This PR causes between 1 and 10 packages to rebuild on Darwin. 10.rebuild-linux: 1-10 This PR causes between 1 and 10 packages to rebuild on Linux. labels May 5, 2022
@lovesegfault lovesegfault merged commit 764bba5 into NixOS:master May 6, 2022
@lovesegfault lovesegfault deleted the igm-fixup branch May 6, 2022 01:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

10.rebuild-darwin: 1-10 This PR causes between 1 and 10 packages to rebuild on Darwin. 10.rebuild-linux: 1-10 This PR causes between 1 and 10 packages to rebuild on Linux.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants