Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

aws_shell: 0.1.0 -> 0.1.1 #17117

Merged
merged 1 commit into from
Jul 20, 2016
Merged

aws_shell: 0.1.0 -> 0.1.1 #17117

merged 1 commit into from
Jul 20, 2016

Conversation

cransom
Copy link
Contributor

@cransom cransom commented Jul 19, 2016

Motivation for this change

Updates and a bug fix.

Things done
  • Tested using sandboxing
    (nix.useChroot on NixOS,
    or option build-use-chroot in nix.conf
    on non-NixOS)
  • Built on platform(s)
    • NixOS
    • OS X
    • Linux
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nox --run "nox-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Fits CONTRIBUTING.md.

This also fixes awslabs/aws-shell#118

};
propagatedBuildInputs = with self; [
configobj prompt_toolkit_52 awscli boto3 pygments sqlite3 mock pytest
configobj prompt_toolkit awscli boto3 pygments sqlite3 mock pytest
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Is the _52 one still needed by other things?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

haxor-news appears to still be using it.

@grahamc
Copy link
Member

grahamc commented Jul 20, 2016

Tested locally, works a treat. Thanks!


Reviewed 1 of 1 files at r1.
Review status: all files reviewed at latest revision, 1 unresolved discussion, some commit checks broke.


Comments from Reviewable

@grahamc grahamc merged commit fdd84fd into NixOS:master Jul 20, 2016
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Error on first run - TypeError: generate_shorthand_example() takes exactly 4 arguments (3 given)
3 participants