[21.11] docker: 2.10.9 -> 20.10.14 (for glibc 2.34 compatiblity!)#170900
Merged
amaxine merged 4 commits intoNixOS:release-21.11from Apr 29, 2022
Merged
[21.11] docker: 2.10.9 -> 20.10.14 (for glibc 2.34 compatiblity!)#170900amaxine merged 4 commits intoNixOS:release-21.11from
amaxine merged 4 commits intoNixOS:release-21.11from
Conversation
(cherry picked from commit 18d0fe9)
https://docs.docker.com/engine/release-notes/#201013 (cherry picked from commit b73b403)
The patch incorporates changes merged into the upstream in this PR: moby/moby#43136 (cherry picked from commit 3d25f04)
https://docs.docker.com/engine/release-notes/#201014 (cherry picked from commit ae79018)
13903cf to
4f66697
Compare
Contributor
Author
|
|
Contributor
Author
|
nixpkgs-review is also happy: |
mikroskeem
approved these changes
Apr 29, 2022
Merged
13 tasks
flokli
added a commit
to wireapp/wire-server
that referenced
this pull request
Jun 8, 2022
glibc 2.34 uses the clone3 syscall, which is not part of the seccomp filters that moby ships on older versions. While as a workaround you might be able to run containers with `--privileged`, it's the better call to just run a more recent Docker runtime. References: - docker/buildx#772 - moby/buildkit#2379 - moby/moby#42836 - NixOS/nixpkgs#170900
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description of changes
We've hit an issue on our build servers that run Docker on NixOS 21.11. The problem is that the docker 2.10.9 is incompatible with glibc 2.34. The symptom is that applications using glibc 2.34 will die with
EPERMfrom aclone3system call.Ironically, this prevents new Nix binaries from working. We noticed the issue when even
nix-shell --versionwould just die withPermission denied.Information on the issue can be found here:
I've backported from master:
This brings docker to 2.10.14. According to their release notes, this also fixes two security issues:
Will mark as ready for review when the tests completed.
Things done
sandbox = trueset innix.conf? (See Nix manual)nix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage./result/bin/)nixos/doc/manual/md-to-db.shto update generated release notes