binutils-unwrapped-all-targets: fix libctf breakage#169907
Merged
trofi merged 1 commit intoNixOS:masterfrom Apr 30, 2022
Merged
binutils-unwrapped-all-targets: fix libctf breakage#169907trofi merged 1 commit intoNixOS:masterfrom
trofi merged 1 commit intoNixOS:masterfrom
Conversation
Before the change 'postFixup' was breaking binaries as it deleted `libctf.so`'s dependency without fixing the links (https://hydra.nixos.org/build/173957444): objdump: symbol lookup error: ...-binutils-2.38/lib/libctf.so.0: undefined symbol: htab_eq_string Instead of tying binutils and libbfd together let's stop replacing the libraries and use local copies. They are not mechanically interchangeable. Ideally binutils' upstream build system should allow linking external `libbfd`/`libopcodes`/`libctf` but we are not there yet.
ofborg
bot
added
10.rebuild-darwin: 1-10
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Before the change 'postFixup' was breaking binaries as it deleted
libctf.so'sdependency without fixing the links (https://hydra.nixos.org/build/173957444):
objdump:
symbol lookup error: ...-binutils-2.38/lib/libctf.so.0: undefined symbol: htab_eq_string
Instead of tying binutils and libbfd together let's stop replacing the
libraries and use local copies. They are not mechanically interchangeable.
Ideally binutils' upstream build system should allow linking external
libbfd/libopcodes/libctfbut we are not there yet.Description of changes
Things done
sandbox = trueset innix.conf? (See Nix manual)nix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage./result/bin/)nixos/doc/manual/md-to-db.shto update generated release notes