binutils: fix cross compilation from darwin#169345
Merged
lovesegfault merged 1 commit intoNixOS:masterfrom Apr 19, 2022
Merged
Conversation
The libtool patch is required to correctly invoke the linker while building, so it should depend on the build toolchain.
lovesegfault
approved these changes
Apr 19, 2022
Member
lovesegfault
left a comment
There was a problem hiding this comment.
LGTM, thanks for the fix!
Member
|
I imagine it needs to hit staging, not master? |
Member
|
Well, seems like it doesn't trigger as many rebuilds as I thought. I'm going to merge it. |
Member
Author
Fortunately it only affects cross, so very few rebuilds. Hydra evaluation to see the effects: https://hydra.nixos.org/eval/1756673 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The libtool patch is required to correctly invoke the linker while
building, so it should depend on the build toolchain.
Description of changes
Addressing breakage reported in #134917 (comment)
This is only part of the story. There's still a problem with glibc and
separateDebugInfo. If I turn that off I can buildpkgsCross.aarch64-multiplatform.hellofromx86_64-darwinvia rosetta.Things done
sandbox = trueset innix.conf? (See Nix manual)nix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage./result/bin/)nixos/doc/manual/md-to-db.shto update generated release notes