Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

neovim: 0.6.0 -> 0.7.0 #168846

Merged
merged 1 commit into from
Apr 16, 2022
Merged

neovim: 0.6.0 -> 0.7.0 #168846

merged 1 commit into from
Apr 16, 2022

Conversation

tfmoraes
Copy link
Contributor

@tfmoraes tfmoraes commented Apr 16, 2022 •
edited
Loading

Description of changes
Things done
  • Built on platform(s)
    • x86_64-linux
    • aarch64-linux
    • x86_64-darwin
    • aarch64-darwin
  • For non-Linux: Is sandbox = true set in nix.conf? (See Nix manual)
  • Tested, as applicable:
  • Tested compilation of all packages that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage
  • Tested basic functionality of all binary files (usually in ./result/bin/)
  • 22.05 Release Notes (or backporting 21.11 Release notes)
    • (Package updates) Added a release notes entry if the change is major or breaking
    • (Module updates) Added a release notes entry if the change is significant
    • (Module addition) Added a release notes entry if adding a new NixOS module
    • (Release notes changes) Ran nixos/doc/manual/md-to-db.sh to update generated release notes
  • Fits CONTRIBUTING.md.

@ofborg ofborg bot requested review from manveru, rvolosatovs and Ma27 April 16, 2022 01:10
oxalica
oxalica approved these changes Apr 16, 2022
View reviewed changes
Copy link
Contributor

@oxalica oxalica left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Tested with my set of configurations and plugins. Met no issues yet.

@Tungsten842
Copy link
Member

Result of nixpkgs-review pr 168846 run on x86_64-linux 1

7 packages built:
  • gnvim
  • neovim-qt
  • neovim-qt-unwrapped
  • neovim-remote
  • neovim-unwrapped
  • nvimpager
  • vimPlugins.minimap-vim

@minijackson
Copy link
Member

minijackson commented Apr 16, 2022 •
edited
Loading

Also tested with my config, and it seems to work fine. I personally think it would be nice to merge this before the feature freeze (#167025)

Result of nixpkgs-review pr 168846 run on x86_64-linux 1

7 packages built:
  • gnvim
  • neovim-qt
  • neovim-qt-unwrapped
  • neovim-remote
  • neovim-unwrapped
  • nvimpager
  • vimPlugins.minimap-vim

@teto teto merged commit 0e9bebe into NixOS:master Apr 16, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@oxalica oxalica oxalica approved these changes

@jonringer jonringer Awaiting requested review from jonringer

@teto teto Awaiting requested review from teto teto is a code owner

@manveru manveru Awaiting requested review from manveru

@rvolosatovs rvolosatovs Awaiting requested review from rvolosatovs

@Ma27 Ma27 Awaiting requested review from Ma27

Assignees
No one assigned
Labels
6.topic: vim 10.rebuild-darwin: 1-10 10.rebuild-linux: 1-10
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@tfmoraes @Tungsten842 @minijackson @oxalica @teto