cudaPackages.cudnn: use libcublas if available#168755
cudaPackages.cudnn: use libcublas if available#168755FRidh wants to merge 1 commit intoNixOS:masterfrom
Conversation
Additionally, perform the patching using hooks. Note that cudatoolkit is no longer propagated. This may cause some breakage.
|
Duplicate of #168748. |
ofborg
bot
added
10.rebuild-darwin: 1-10
| , cudatoolkit | ||
| , cudatoolkit ? null | ||
| , libcublas ? null | ||
| , zlib ? null |
There was a problem hiding this comment.
Required regardless of which cudatoolkit distribution: cudnn on master is broken
There was a problem hiding this comment.
Interesting, I thought ldd showed all was good before.
|
|
||
| nativeBuildInputs = [ addOpenGLRunpath ]; | ||
| nativeBuildInputs = [ | ||
| autoAddOpenGLRunpathHook |
There was a problem hiding this comment.
I didn't know there way such a hook. Is this new?
There was a problem hiding this comment.
Yes I created it in the redist packages PR.
| majorMinorPatch = version: lib.concatStringsSep "." (lib.take 3 (lib.splitVersion version)); | ||
| version = majorMinorPatch fullVersion; | ||
| # Use libcublas if available | ||
| withoutCudaToolkit = libcublas != null; |
There was a problem hiding this comment.
What's the reason to have a version with libcublas and another without? Is it purely for backwards compatibility with derivations still based on cudatoolkit?
There was a problem hiding this comment.
Ah ok, so we only have redist packages for CUDA 11.4-11.6 currently. But according to https://developer.download.nvidia.com/compute/cuda/redist/ there are redist packages for all CUDA 11.x versions.
@FRidh is there a reason that we don't have redist packages for CUDA 11.0-11.3 as well as 11.4-11.6?
There was a problem hiding this comment.
Can we move this boolean flag to the top-level? We shouldn't introduce more ? null bug-hiding traps.
There was a problem hiding this comment.
@FRidh is there a reason that we don't have redist packages for CUDA 11.0-11.3 as well as 11.4-11.6?
there are unfortunately only manifest files for 11.4 to 11.6
Can we move this boolean flag to the top-level? We shouldn't introduce more ? null bug-hiding traps.
@SuperSandro2000 could you stop this nonsense. There is nothing wrong with adding ? null if you handle it. This boolean isn't an option, and is only there because this function is called for several versions, and for older versions the required attribute does not exist.
There was a problem hiding this comment.
Oh I see. There are manifest files for all of 11.x but they are mostly empty up until 11.4.2
There was a problem hiding this comment.
There is nothing wrong with adding ? null if you handle it.
It is playing with fire. It is very easy to get things wrong and don't even notice it.
|
merged #168748 |
4 participants
Additionally, perform the patching using hooks.
Note that cudatoolkit is no longer propagated. This may cause some
breakage.
Description of changes
Things done
sandbox = trueset innix.conf? (See Nix manual)nix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage./result/bin/)nixos/doc/manual/md-to-db.shto update generated release notes