Skip to content

re2: add some key reverse dependencies to passthru.tests#167099

Merged
SuperSandro2000 merged 1 commit intoNixOS:masterfrom
risicle:ris-re2-passthru-tests
May 9, 2022
Merged

re2: add some key reverse dependencies to passthru.tests#167099
SuperSandro2000 merged 1 commit intoNixOS:masterfrom
risicle:ris-re2-passthru-tests

Conversation

@risicle
Copy link
Contributor

@risicle risicle commented Apr 3, 2022

Description of changes

Packages that have a large reverse dependency set are hard to test because a full rebuild is infeasible. But on the other hand, it's tricky for reviewers to remember which reverse dependencies of a particular package are particularly important to ensure are working or are known to be particularly sensitive to changes in the depended package.

Therefore it makes sense to add a small selection of such packages to passthru.tests. Done here for re2.

See also #167079 and #167092 in the same vein

Things done
  • Built on platform(s)
    • x86_64-linux
    • aarch64-linux
    • x86_64-darwin
    • aarch64-darwin
  • For non-Linux: Is sandbox = true set in nix.conf? (See Nix manual)
  • Tested, as applicable:
  • Tested compilation of all packages that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage
  • Tested basic functionality of all binary files (usually in ./result/bin/)
  • 22.05 Release Notes (or backporting 21.11 Release notes)
    • (Package updates) Added a release notes entry if the change is major or breaking
    • (Module updates) Added a release notes entry if the change is significant
    • (Module addition) Added a release notes entry if adding a new NixOS module
    • (Release notes changes) Ran nixos/doc/manual/md-to-db.sh to update generated release notes
  • Fits CONTRIBUTING.md.

@ofborg ofborg bot added 10.rebuild-darwin: 0 This PR does not cause any packages to rebuild on Darwin. 10.rebuild-linux: 0 This PR does not cause any packages to rebuild on Linux. labels Apr 3, 2022
@Artturin Artturin added the 8.has: tests This PR has tests label Apr 4, 2022
@risicle risicle force-pushed the ris-re2-passthru-tests branch from 7ffe2ae to 12c1a06 Compare April 15, 2022 12:33
@SuperSandro2000 SuperSandro2000 merged commit 71f11b8 into NixOS:master May 9, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

8.has: tests This PR has tests 10.rebuild-darwin: 0 This PR does not cause any packages to rebuild on Darwin. 10.rebuild-linux: 0 This PR does not cause any packages to rebuild on Linux.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants