Skip to content

boost17x: 1.77 -> 1.78#166445

Closed
TheBenCollins wants to merge 4 commits intoNixOS:stagingfrom
TheBenCollins:add-boost-178
Closed

boost17x: 1.77 -> 1.78#166445
TheBenCollins wants to merge 4 commits intoNixOS:stagingfrom
TheBenCollins:add-boost-178

Conversation

@TheBenCollins
Copy link
Contributor

Description of changes

Added the December 2021 release of Boost, 1.78.0. This PR not only adds a new package, pkgs.boost178, but also moves the indirect package pkgs.boost17x to point to the new library. This later change is more substantive as there are many other derivations that depend on this meta-package.

Things done
  • Built on platform(s)
    • [ x ] x86_64-linux
      I ran nix-build -A pkgs.boost178 . from the local clone of nixpkgs and got a proper result.

I was not able to run nixpkgs-review in a reasonable amount of time (was ongoing for many hours) so this check is left undone.

@ofborg ofborg bot added the 8.has: package (new) This PR adds a new package label Mar 30, 2022
@ofborg ofborg bot added 10.rebuild-darwin: 501+ This PR causes many rebuilds on Darwin and should normally target the staging branches. 10.rebuild-darwin: 5001+ This PR causes many rebuilds on Darwin and must target the staging branches. 10.rebuild-linux: 501+ This PR causes many rebuilds on Linux and should normally target the staging branches. 10.rebuild-linux: 5001+ This PR causes many rebuilds on Linux and must target the staging branches. labels Mar 30, 2022
@ajs124
Copy link
Member

ajs124 commented Mar 30, 2022

Thanks for your contribution.
Some notes: This should go to staging, because it rebuilds >5k packages. Also, the commit messages don't follow CONTRIBUTING.md, I think.

For how to change the target branch to staging without spamming a bunch of people, maybe check #166472 or CONTRIBUTING.md, once it's merged.

@TheBenCollins TheBenCollins changed the base branch from master to staging April 1, 2022 16:22
@ofborg ofborg bot added the 2.status: merge conflict This PR has merge conflicts with the target branch label Apr 1, 2022
@TheBenCollins
Copy link
Contributor Author

@ajs124 I rebased onto staging as was requested. (I followed the directions in #166472). Let me know if there is anything else to work out.

@ofborg ofborg bot removed the 2.status: merge conflict This PR has merge conflicts with the target branch label Apr 1, 2022
@ajs124
Copy link
Member

ajs124 commented Apr 1, 2022

Thanks! The commit messages should follow the pattern outlined here. I know it's kind of pedantic, but it makes commit logs easier to read IMO.

@dotlambda
Copy link
Member

superseded by #175694

@dotlambda dotlambda closed this Jun 1, 2022
@Janik-Haag Janik-Haag added the 12.first-time contribution This PR is the author's first one; please be gentle! label Jun 12, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

8.has: package (new) This PR adds a new package 10.rebuild-darwin: 501+ This PR causes many rebuilds on Darwin and should normally target the staging branches. 10.rebuild-darwin: 5001+ This PR causes many rebuilds on Darwin and must target the staging branches. 10.rebuild-linux: 501+ This PR causes many rebuilds on Linux and should normally target the staging branches. 10.rebuild-linux: 5001+ This PR causes many rebuilds on Linux and must target the staging branches. 12.first-time contribution This PR is the author's first one; please be gentle!

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants