Closed
Conversation
Member
|
Thanks for your contribution. For how to change the target branch to staging without spamming a bunch of people, maybe check #166472 or CONTRIBUTING.md, once it's merged. |
…ost17x to point to boost178
44f6a79 to
62d294c
Compare
Contributor
Author
Member
|
Thanks! The commit messages should follow the pattern outlined here. I know it's kind of pedantic, but it makes commit logs easier to read IMO. |
Member
|
superseded by #175694 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description of changes
Added the December 2021 release of Boost, 1.78.0. This PR not only adds a new package,
pkgs.boost178, but also moves the indirect packagepkgs.boost17xto point to the new library. This later change is more substantive as there are many other derivations that depend on this meta-package.Things done
I ran
nix-build -A pkgs.boost178 .from the local clone of nixpkgs and got a proper result.I was not able to run
nixpkgs-reviewin a reasonable amount of time (was ongoing for many hours) so this check is left undone.