Skip to content

mepo: 0.3 -> 0.4.1#165600

Merged
SuperSandro2000 merged 1 commit intoNixOS:masterfrom
McSinyx:mepo-0.4
Apr 25, 2022
Merged

mepo: 0.3 -> 0.4.1#165600
SuperSandro2000 merged 1 commit intoNixOS:masterfrom
McSinyx:mepo-0.4

Conversation

@McSinyx
Copy link
Member

@McSinyx McSinyx commented Mar 24, 2022

Things done
  • Built on platform(s)
    • x86_64-linux
    • aarch64-linux
    • x86_64-darwin
    • aarch64-darwin
  • For non-Linux: Is sandbox = true set in nix.conf? (See Nix manual)
  • Tested, as applicable:
  • Tested compilation of all packages that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage
  • Tested basic functionality of all binary files (usually in ./result/bin/)
  • 22.05 Release Notes (or backporting 21.11 Release notes)
    • (Package updates) Added a release notes entry if the change is major or breaking
    • (Module updates) Added a release notes entry if the change is significant
    • (Module addition) Added a release notes entry if adding a new NixOS module
    • (Release notes changes) Ran nixos/doc/manual/md-to-db.sh to update generated release notes
  • Fits CONTRIBUTING.md.

@McSinyx McSinyx requested a review from sikmir March 24, 2022 11:49
@ofborg ofborg bot added 8.has: package (new) This PR adds a new package 10.rebuild-darwin: 1-10 This PR causes between 1 and 10 packages to rebuild on Darwin. 10.rebuild-linux: 1-10 This PR causes between 1 and 10 packages to rebuild on Linux. labels Mar 24, 2022
@sikmir
Copy link
Member

sikmir commented Mar 24, 2022

Changelog

sikmir
sikmir reviewed Mar 24, 2022
View reviewed changes
@McSinyx McSinyx force-pushed the mepo-0.4 branch 2 times, most recently from 1155eb8 to 5b35d00 Compare March 25, 2022 09:30
@ofborg ofborg bot added the 8.has: clean-up This PR removes packages or removes other cruft label Mar 25, 2022
@ofborg ofborg bot requested a review from sikmir March 25, 2022 09:44
@ofborg ofborg bot added 11.by: package-maintainer This PR was created by a maintainer of all the package it changes. 10.rebuild-darwin: 0 This PR does not cause any packages to rebuild on Darwin. and removed 10.rebuild-darwin: 1-10 This PR causes between 1 and 10 packages to rebuild on Darwin. labels Mar 25, 2022
SuperSandro2000
SuperSandro2000 reviewed Mar 27, 2022
View reviewed changes
SuperSandro2000
SuperSandro2000 reviewed Mar 27, 2022
View reviewed changes
@McSinyx McSinyx force-pushed the mepo-0.4 branch 2 times, most recently from 3e74119 to d38e369 Compare April 24, 2022 07:43
SuperSandro2000
SuperSandro2000 reviewed Apr 24, 2022
View reviewed changes
@McSinyx McSinyx requested a review from SuperSandro2000 April 25, 2022 04:28
sikmir
sikmir reviewed Apr 25, 2022
View reviewed changes
@bobby285271
Copy link
Member

bobby285271 commented Apr 25, 2022 •
edited
Loading

@ofborg eval

@McSinyx
Copy link
Member Author

McSinyx commented Apr 25, 2022

I do not understand how the ofborg failure is related to this update. Any clue?

@bobby285271
Copy link
Member

bobby285271 commented Apr 25, 2022

For The branch this PR will merge in to does not cleanly evaluate, and so this PR cannot be checked., the failure is not related to this PR (but the base branch), it should be fixed in #170193

@ofborg ofborg bot requested a review from sikmir April 25, 2022 05:36
SuperSandro2000
SuperSandro2000 reviewed Apr 25, 2022
View reviewed changes
pkgs/applications/misc/mepo/default.nix Outdated
Copy link
Member

@SuperSandro2000 SuperSandro2000 Apr 25, 2022

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
wrapProgram $prog --prefix PATH : $out/bin
wrapProgram $prog --suffix PATH : $out/bin

Copy link
Member Author

@McSinyx McSinyx Apr 25, 2022

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Should $out/bin be preferred over what's already in PATH?

@SuperSandro2000 SuperSandro2000 merged commit f925cb6 into NixOS:master Apr 25, 2022
@McSinyx
Copy link
Member Author

McSinyx commented Apr 25, 2022

Thank you all for suggestions over time, I learnt a lot!

@McSinyx McSinyx deleted the mepo-0.4 branch April 25, 2022 13:39
@McSinyx McSinyx restored the mepo-0.4 branch April 29, 2022 10:47
@McSinyx McSinyx deleted the mepo-0.4 branch April 29, 2022 10:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@SuperSandro2000 SuperSandro2000 SuperSandro2000 left review comments

@sikmir sikmir Awaiting requested review from sikmir

Assignees

No one assigned

Labels

8.has: clean-up This PR removes packages or removes other cruft 8.has: package (new) This PR adds a new package 10.rebuild-darwin: 0 This PR does not cause any packages to rebuild on Darwin. 10.rebuild-linux: 1-10 This PR causes between 1 and 10 packages to rebuild on Linux. 11.by: package-maintainer This PR was created by a maintainer of all the package it changes.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@McSinyx @sikmir @bobby285271 @SuperSandro2000